Add genre and language metadata to storylines

[realproject7]

Summary

• Migration 00014_genre_language.sql: adds genre (nullable) and language (default 'English') columns with indexes
• Types: lib/supabase.ts updated with genre/language fields
• Constants: new lib/genres.ts with GENRES (21 options) and LANGUAGES (11 options) arrays
• Create form: genre dropdown (required, no default) and language dropdown (default English) between title and content
• usePublish: forwards optional metadata to indexer POST body
• Storyline indexer: accepts and stores genre/language from request body
• Discovery page: genre and language filter dropdowns alongside existing writer filter; applied to new/completed tabs (trending/rising use ranking lib, genre/lang filtering deferred)
• StoryCard: displays genre badge; non-English language badge
• Story detail: genre + language shown in header metadata area
• Backfill cron leaves defaults (genre=null, language='English') for historical storylines

Fixes #265

Test plan

• Genre dropdown required on create page — form won't submit without selection
• Language defaults to English, changeable
• Genre/language stored in Supabase after storyline creation
• Discovery page genre/language filters work on new + completed tabs
• Genre badge on story cards; language badge only for non-English
• Genre + language on story detail page
• Existing storylines show no genre badge (null) and no language badge (English default)
• npm run typecheck passes

🤖 Generated with Claude Code

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The metadata flow and display updates are mostly in place, but the discovery filters do not satisfy the ticket requirement across all four tabs.

Findings

• [medium] genre / language filters are ignored on the trending and rising tabs. queryTab() applies the new filters only to the direct Supabase queries for new and completed, while trending and rising still delegate straight to getTrendingStorylines() / getRisingStorylines() with only the writer-type filter. This means the UI shows genre/language dropdowns, but those tabs return unfiltered results.
  • File: src/app/page.tsx:186
  • Suggestion: thread genre and lang through the ranking queries as well, or apply equivalent filtering before returning those ranked results.

Decision

Request changes. The ticket explicitly requires genre/language filtering on all four discovery tabs, so the trending and rising paths need to honor the new filters before merge.

[project7-interns]

REQUEST CHANGES — one blocking issue.

Blocking: No server-side validation on genre/language in the storyline indexer.

src/app/api/index/storyline/route.ts:31-32 accepts any string from the POST body:

const genre = (body.genre as string | undefined) || null;
const language = (body.language as string | undefined) || "English";

The create form validates on the client (genre required, values from GENRES array), but the API endpoint stores whatever is POSTed. A direct POST to /api/index/storyline can inject arbitrary genre/language strings, polluting the database and breaking filter queries that assume values match the GENRES/LANGUAGES constants.

Fix: validate against the allowed values server-side:

import { GENRES, LANGUAGES } from "../../../../lib/genres";

const rawGenre = body.genre as string | undefined;
const genre = rawGenre && (GENRES as readonly string[]).includes(rawGenre) ? rawGenre : null;
const rawLang = body.language as string | undefined;
const language = rawLang && (LANGUAGES as readonly string[]).includes(rawLang) ? rawLang : "English";

Non-blocking observations:

1. ...opts.metadata spread is untyped — usePublish spreads arbitrary keys into the indexer body. Consider typing metadata as { genre: string; language: string } instead of Record<string, string> to prevent accidental field injection.

2. Overall structure is clean: migration is correct (nullable genre, defaulted language, indexes), applyFilters helper DRYs up the query logic nicely, genre/language display is consistent across StoryCard and story detail, and the filter dropdowns correctly preserve other URL params.

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The trending/rising filter path is fixed, but the storyline indexer still trusts client-supplied metadata without validating it against the allowed genre/language sets.

Findings

• [medium] /api/index/storyline stores arbitrary genre and language strings from the request body. The create form constrains values in the UI, but a direct POST can still write unsupported values into storylines, which then break the intended filter/display invariants. This should be validated server-side against GENRES / LANGUAGES before upsert.
  • File: src/app/api/index/storyline/route.ts:31
  • Suggestion: reject invalid values with 400, or coerce unknown genre to null and unknown language to English using the shared constants.

Decision

Request changes. The filtering implementation is now complete across all four tabs, but the server needs to validate metadata before persisting it.

[project7-interns]

APPROVE

Server-side validation fix confirmed: indexer now validates genre/language against the shared GENRES/LANGUAGES arrays, coercing unknown values to null/"English". This matches the approach I suggested — safe at the API boundary without being overly strict (coerce rather than reject).

Both my blocking issue and T2a's equivalent finding are resolved. The full implementation across migration, types, create form, indexer, discovery filters, and display is solid.

[project7-interns]

Verdict: APPROVE

Summary

The follow-up patches close the remaining gaps in the metadata rollout. Genre/language filters now apply across all four discovery tabs, and the storyline indexer validates client-supplied metadata before persisting it.

Findings

• [info] No blocking issues found in the updated patch.

Decision

Approve. lib/ranking.ts now threads genre/language filters through trending and rising, and /api/index/storyline constrains metadata to the shared GENRES / LANGUAGES sets with safe coercion for invalid inputs. CI was still pending when reviewed.