Skip to content

[#284] Fix false recovery intents from wallet rejection #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realproject7 merged 1 commit into from
Mar 18, 2026
Merged

[#284] Fix false recovery intents from wallet rejection #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 9 additions & 29 deletions src/hooks/usePublish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,20 +42,6 @@ interface PublishOptions {
onIndexed?: () => void;
}

/**
* Returns true if the error is a user-rejected transaction (wallet popup dismissed).
*/
function isUserRejection(err: unknown): boolean {
const message =
err instanceof Error ? err.message.toLowerCase() : String(err).toLowerCase();
return (
message.includes("user rejected") ||
message.includes("user denied") ||
message.includes("rejected the request") ||
message.includes("cancelled")
);
}

/**
* Shared publishing state machine for StoryFactory write flows.
*
Expand Down Expand Up @@ -100,23 +86,22 @@ export function usePublish() {
cachedCid.current = { cid, contentHash };
}

// Save intent before wallet confirmation
opts.onIntentSave?.({
content: opts.content,
metadata: opts.metadata ?? {},
indexerRoute: opts.indexerRoute,
uploadKeyPrefix: opts.uploadKeyPrefix,
});

// 2. Submit tx to wallet
setState("confirming");
const writeCall = opts.buildWriteCall(cid, contentHash);

const hash = await writeContractAsync(writeCall);
setTxHash(hash);

// Persist tx hash immediately after broadcast (before receipt polling)
// so recovery works even if receipt polling fails
// Save intent + tx hash only after wallet signs (not before).
// This avoids false recovery intents when the wallet rejects —
// no intent exists if writeContractAsync throws.
opts.onIntentSave?.({
content: opts.content,
metadata: opts.metadata ?? {},
indexerRoute: opts.indexerRoute,
uploadKeyPrefix: opts.uploadKeyPrefix,
});
opts.onTxConfirmed?.(hash);

// 3. Wait for tx confirmation
Expand Down Expand Up @@ -149,11 +134,6 @@ export function usePublish() {
err instanceof Error ? err.message : "Unknown error";
setError(message);
setState("error");

// User rejected tx — clear intent (no recovery needed)
if (isUserRejection(err)) {
opts.onIndexed?.(); // reuse onIndexed to clear intent
}
}
},
[writeContractAsync],
Expand Down
Loading