Skip to content

[#287] Show Farcaster identity on plot pages#288

Merged
realproject7 merged 1 commit intomainfrom
task/287-plot-farcaster-identity
Mar 18, 2026
Merged

[#287] Show Farcaster identity on plot pages#288
realproject7 merged 1 commit intomainfrom
task/287-plot-farcaster-identity

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Plot detail page: replaced truncateAddress(sl.writer_address) with <WriterIdentity> wrapped in <Suspense> (same pattern as storyline page)
  • OG image route: resolves Farcaster fname server-side via lookupByAddress() in parallel with price fetch, falls back to truncated address

Test plan

  • Plot detail page shows Farcaster @username + avatar for linked writers
  • Plot detail page falls back to truncated address for non-Farcaster writers
  • OG image (/story/{id}/og) shows @username when Farcaster is linked
  • OG image falls back to truncated address when not linked
  • npm run typecheck passes

Fixes #287

🤖 Generated with Claude Code

…ress

- Plot detail page: replace truncateAddress with WriterIdentity in
  Suspense (same pattern as storyline page)
- OG image route: resolve Farcaster fname server-side via
  lookupByAddress, fall back to truncated address

Fixes #287

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review — APPROVED

Clean, minimal change:

  • Plot detail: WriterIdentity in Suspense with truncated address fallback — matches existing storyline page pattern
  • OG route: lookupByAddress in Promise.all with price fetch (no added latency), .catch(() => null) for graceful fallback
  • No new dependencies, no structural changes

Ship it.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The plot detail page now uses the same WriterIdentity pattern as the storyline page, and the OG route resolves Farcaster usernames server-side with a truncated-address fallback when no profile is linked.

Findings

  • No blocking findings from this review pass.

Decision

Approving from my side. GitHub checks were still pending at the time of review.

@realproject7 realproject7 merged commit a2972e9 into main Mar 18, 2026
1 check passed
realproject7 added a commit that referenced this pull request Mar 27, 2026
Implement computeAuthorReputation() combining follower_count,
x_followers_count, x_verified, neynar_score, and quotient_score
as the sixth trend signal at 20% weight. Batch-fetches writer
user rows via primary_address and verified_addresses to avoid
N+1 queries. Rebalances existing signal weights accordingly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] Show Farcaster identity on plot pages instead of truncated address

2 participants