Skip to content

[#298] Update og:image, favicon, and Farcaster manifest assets#301

Merged
realproject7 merged 4 commits intomainfrom
task/298-metadata-assets
Mar 18, 2026
Merged

[#298] Update og:image, favicon, and Farcaster manifest assets#301
realproject7 merged 4 commits intomainfrom
task/298-metadata-assets

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Added icons, openGraph.images, and twitter.images to the root layout metadata
  • Favicon set to /favicon.png, OG and Twitter images set to /og-image.png
  • Farcaster manifest updated with splashImageUrl pointing to splash.png
  • iconUrl already correctly references /icon.png

Fixes #298

Test plan

  • Verify og:image meta tag renders /og-image.png in page source
  • Verify twitter:image meta tag is set
  • Verify favicon shows favicon.png in browser tab
  • Verify Farcaster manifest at /.well-known/farcaster.json includes splashImageUrl
  • npm run build passes

🤖 Generated with Claude Code

- layout.tsx: add icons (favicon.png), openGraph.images and
  twitter.images (og-image.png)
- farcaster.json: add splashImageUrl pointing to splash.png

Fixes #298

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: The metadata references three assets that don't exist in /public:

  • /favicon.png — only icon.png exists
  • /og-image.png — missing
  • splash.png — missing (referenced in farcaster.json)

These will all 404. Either add the asset files to this PR or update the references to use the existing icon.png for favicon/icon. The OG image and splash image need actual files committed.

Note: the issue scope says "update metadata references for the new brand assets in /public" — suggests the assets should already be there. If they haven't been added yet, this PR should include them or the issue needs clarification from T1.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The layout metadata updates are correct, but the Farcaster manifest portion is still incomplete relative to issue #298.

Findings

  • [medium] farcaster.json still omits the manifest OG/promotional image field.
    • File: public/.well-known/farcaster.json:12
    • Suggestion: Add ogImageUrl pointing at the new /og-image.png asset. Issue #298 explicitly asked for the OG/cover image field if the manifest supports it, and current mini app manifest docs do support ogImageUrl.

Decision

Requesting changes because the PR updates openGraph.images and twitter.images, but it does not complete the matching Farcaster manifest asset update required by the issue.

realproject7 and others added 2 commits March 18, 2026 11:14
Include favicon.png, og-image.png, splash.png, icon.png,
embed-image.png, and wide-banner.png — previously untracked.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Previously untracked — referenced by NavBar (PR #299).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous blocker resolved — all referenced assets (favicon.png, og-image.png, splash.png) are now committed. Also includes icon.png update, plotlink-logo-symbol.svg, and bonus assets (embed-image.png, wide-banner.png). LGTM from my side.

Note: T2a's separate finding about ogImageUrl in farcaster.json is still outstanding.

Addresses T2a review: include OG/promotional image field in
the mini app manifest.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The missing Farcaster manifest image field has been added, and the referenced brand assets are now committed in the PR.

Findings

  • No blocking findings.

Decision

Approving because the metadata updates now cover favicon, Open Graph, Twitter, and Farcaster manifest assets as required by issue #298.

@realproject7 realproject7 merged commit 8fa1f6c into main Mar 18, 2026
1 check passed
realproject7 added a commit that referenced this pull request Mar 27, 2026
Remove the "How to Get PLOT" section. Add USD equivalent below the
PLOT balance amount using the existing token price data from
useTokenInfo(). Only shown when balance > 0 and price is available.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PlotLink: Update og:image, favicon, and Farcaster manifest with new assets

2 participants