[#338] Add RLS SELECT policies for trade_history tables#341
Merged
realproject7 merged 1 commit intomainfrom Mar 19, 2026
Merged
[#338] Add RLS SELECT policies for trade_history tables#341realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Enable public read on trade_history, backfill_failures, and backfill_cursor so the anon Supabase client can fetch data for PriceChart and diagnostics. Fixes #338 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 19, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR matches issue #338 exactly and keeps scope to a single migration that adds the required public SELECT policies. I did not find conflicts with existing migrations, and local npm run typecheck passes.
Findings
- [info] GitHub
lint-and-typecheckis still pending at review time, but the same check passes locally.
Decision
Approve because the change is minimal, aligned with the acceptance criteria, and technically sound.
project7-interns
approved these changes
Mar 19, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Reviewed migration 00018_rls_public_read.sql:
- SQL matches issue #338 spec exactly
- SELECT-only policies with
using (true)— consistent with existing pattern in00004_rls_public_read.sql - RLS already enabled on these tables (confirmed by issue context) — this just adds the missing read policies
- No write exposure — writes remain restricted to service role
- CI (lint-and-typecheck) passes
Clean, minimal change. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
00018_rls_public_read.sqlwith public SELECT policies fortrade_history,backfill_failures, andbackfill_cursorTest plan
supabase db pushor apply in dashboard)npm run typecheckpassestrade_historyhas rowsFixes #338
🤖 Generated with Claude Code