Skip to content

[#346] Send MCV2_Bond creation fee in createStoryline frontend#347

Merged
realproject7 merged 1 commit intomainfrom
task/346-creation-fee-frontend
Mar 19, 2026
Merged

[#346] Send MCV2_Bond creation fee in createStoryline frontend#347
realproject7 merged 1 commit intomainfrom
task/346-creation-fee-frontend

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Fetch creationFee() dynamically from MCV2_Bond via useQuery
  • Pass value: creationFee in buildWriteCall for createStoryline
  • Display creation fee to user in the create form ("Creation fee: 0.0007 ETH")
  • Add value field to WriteCall interface in usePublish.ts

Test plan

  • npm run typecheck passes
  • npm run build passes
  • On mainnet: createStoryline sends 0.0007 ETH and succeeds
  • On testnet: fee is 0, no value sent, still works

Fixes #346

🤖 Generated with Claude Code

Fetch creationFee() from MCV2_Bond dynamically and pass as value
in the createStoryline write call. Display fee to user in the
create form. Add value field to WriteCall interface.

Fixes #346

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR fixes the mainnet creation-fee bug in the frontend by reading creationFee() from MCV2_Bond, passing it through the write call, and surfacing it in the create UI. The write path and local verification both check out.

Findings

  • [info] src/app/create/page.tsx now fetches creationFee() from MCV2_Bond and passes it as value in the createStoryline write call, while usePublish accepts and forwards the optional value field.

Decision

Approve because the frontend now sends the required creation fee on mainnet and keeps testnet behavior compatible when the fee is zero.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE

  • Dynamic creationFee() fetch via useQuery with 1-min staleTime — correct, fee can change ✓
  • Default BigInt(0) — safe for testnet where fee is 0 ✓
  • value: creationFee passed in buildWriteCall
  • User-facing fee display (conditional on fee > 0) with formatEther
  • WriteCall interface extended with optional value?: bigint
  • CI green (typecheck + build)

LGTM.

@realproject7 realproject7 merged commit ae359e9 into main Mar 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Mainnet Bug] Send MCV2_Bond creation fee in createStoryline frontend

2 participants