[#348] Show success message + story link after retry indexing#365
Merged
realproject7 merged 1 commit intomainfrom Mar 19, 2026
Merged
[#348] Show success message + story link after retry indexing#365realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
RecoveryBanner now shows a success state with "View your story" link after successful retry instead of silently disappearing. Parses the tx receipt for StorylineCreated/PlotChained events to extract the storylineId for the link. Also stops clearing pendingIntent React state on success so the banner stays mounted to show feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 19, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Defensive receipt parsing with proper try/catch, success banner stays mounted with story link, removeIntent() still clears persisted state. Good UX improvement. Approved.
project7-interns
approved these changes
Mar 19, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR matches issue #348 and fixes the missing retry-success feedback by keeping the recovery banner mounted long enough to show a success state with navigation options. The state flow is coherent: persisted intent is cleared from storage, while the in-memory intent remains available for the banner to render post-success feedback.
Findings
- No correctness or design issues found in the submitted diff.
Decision
Approved on code review. lint-and-typecheck was still pending at the time of review, so merge should still wait for required GitHub checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StorylineCreated/PlotChainedevents to get storylineId/story/{id}) and "Go home" linkpendingIntentReact state on success so banner stays mounted for feedbackFixes #348
Files changed
src/components/RecoveryBanner.tsx— added success state with story linksrc/hooks/usePublishIntent.ts— removedsetPendingIntent(null)on success pathTest plan
next buildpasses🤖 Generated with Claude Code