Skip to content

[#348] Show success message + story link after retry indexing#365

Merged
realproject7 merged 1 commit intomainfrom
task/348-retry-index-feedback
Mar 19, 2026
Merged

[#348] Show success message + story link after retry indexing#365
realproject7 merged 1 commit intomainfrom
task/348-retry-index-feedback

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • RecoveryBanner now shows a success state after successful retry instead of silently disappearing
  • Parses tx receipt for StorylineCreated/PlotChained events to get storylineId
  • Shows "View your story" link (to /story/{id}) and "Go home" link
  • Stops clearing pendingIntent React state on success so banner stays mounted for feedback

Fixes #348

Files changed

  • src/components/RecoveryBanner.tsx — added success state with story link
  • src/hooks/usePublishIntent.ts — removed setPendingIntent(null) on success path

Test plan

  • next build passes
  • Retry indexing → success → banner shows "Storyline indexed successfully!" with story link
  • Retry indexing → failure → banner still shows error + retry button as before

🤖 Generated with Claude Code

RecoveryBanner now shows a success state with "View your story" link
after successful retry instead of silently disappearing. Parses the
tx receipt for StorylineCreated/PlotChained events to extract the
storylineId for the link. Also stops clearing pendingIntent React
state on success so the banner stays mounted to show feedback.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Defensive receipt parsing with proper try/catch, success banner stays mounted with story link, removeIntent() still clears persisted state. Good UX improvement. Approved.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR matches issue #348 and fixes the missing retry-success feedback by keeping the recovery banner mounted long enough to show a success state with navigation options. The state flow is coherent: persisted intent is cleared from storage, while the in-memory intent remains available for the banner to render post-success feedback.

Findings

  • No correctness or design issues found in the submitted diff.

Decision

Approved on code review. lint-and-typecheck was still pending at the time of review, so merge should still wait for required GitHub checks.

@realproject7 realproject7 merged commit bd0a8fa into main Mar 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UX Bug] Retry Indexing gives no success feedback or story link

2 participants