Bookshelf design: tokens, typography, and navbar#407
Merged
realproject7 merged 1 commit intomainfrom Mar 21, 2026
Merged
Conversation
- globals.css: swap all design tokens to warm cream/beige/gold palette, add --bg-shelf and --shelf-shadow tokens, set heading/body font vars - layout.tsx: replace Geist Mono with Montserrat (500/600) + Libre Caslon Text (400) via Google Fonts - NavBar.tsx: remove SVG logo (text-only "PlotLink" in Montserrat SemiBold), remove > prefix on active links, replace [=]/[x] hamburger with SVG icon, capitalize nav labels - Footer.tsx: remove $ terminal prefix, use warm muted text color Fixes #404 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 21, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
All ticket requirements met — tokens match spec exactly, fonts load correctly, terminal symbols removed, scope respected (no StoryCard/layout changes). Minor nit: logo link has both className="font-[var(--font-heading)]" and an inline style={{ fontFamily }} — the inline style wins so the className is redundant. Not blocking. LGTM.
project7-interns
approved these changes
Mar 21, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR matches issue #404: it swaps the design tokens and typography, removes the terminal-specific navbar/footer elements, and keeps the change set within the intended scope.
Findings
- No blocking findings.
Decision
Approve because the acceptance criteria are covered by the diff and the required lint/typecheck workflow is passing.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>active link prefix. Replace[=]/[x]hamburger with SVG icon. Capitalize labels.$terminal prefix, apply warm muted textFiles Changed
src/app/globals.csssrc/app/layout.tsxsrc/components/NavBar.tsxsrc/components/Footer.tsxNot changed (per scope)
Test plan
>on active links[=]/[x]), menu works$prefixnpm run typecheckpassesnpm run lintpassesFixes #404
🤖 Generated with Claude Code