Skip to content

[#406] Warm bookshelf theme for detail pages and components#409

Merged
realproject7 merged 2 commits intomainfrom
task/406-detail-pages-theme
Mar 21, 2026
Merged

[#406] Warm bookshelf theme for detail pages and components#409
realproject7 merged 2 commits intomainfrom
task/406-detail-pages-theme

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • OG image: Replaced dark terminal colors (#0a0a0a, #00ff88) with warm palette (#E8DFD0, #DAAA63, #2C1810)
  • Farcaster manifest + miniapp embed: splashBackgroundColor updated from #0a0a0a to #E8DFD0
  • Story detail page: Title uses serif font (font-body), price/supply values in gold accent, genesis content wrapped in warm surface panel
  • Error text: All text-red-400 replaced with text-error design token across 6 component files
  • Trading/donate widgets: Monetary values use gold accent instead of plain foreground

No data fetching, API, or business logic changes. All files already used design tokens for most styling; this PR catches the remaining hard-coded colors and applies thematic polish.

Fixes #406

Test plan

  • OG image at /story/[id]/og renders with warm palette
  • Story detail page title is serif, prices are gold
  • Genesis content has warm surface panel
  • Error states show --error color, not Tailwind red-400
  • No hard-coded dark colors remain in component files
  • npm run typecheck passes
  • npm run lint passes

🤖 Generated with Claude Code

- OG image: warm cream bg, gold accent text, serif font
- Farcaster manifest + miniapp embed: warm splash background
- Story detail: serif title, gold price/supply values, surface panel for content
- Replace all text-red-400 with text-error design token (10 files)
- Trading/donate widgets: gold accent for monetary values

Fixes #406

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The PR moves several detail-page components toward the warm theme, but it does not cover the full scope required by issue #406. The required CI check is also still pending.

Findings

  • [high] The PR is incomplete relative to issue #406. The changed-file list includes only 10 files and does not touch several components/pages explicitly called out in scope: src/components/PriceChart.tsx, src/components/RecoveryBanner.tsx, src/app/create/page.tsx, src/app/register-agent/page.tsx, and src/components/WriterTradingStats.tsx. Since #406 is the cleanup pass for remaining themed surfaces, leaving those untouched means the acceptance criteria for trading/dashboard/forms/global styling are not met yet.
    • File: src/components/PriceChart.tsx:1
    • Suggestion: Complete the remaining scope items from issue #406, or explicitly narrow the issue/PR scope before resubmitting.

Decision

Request changes because the implementation is materially incomplete versus the issue requirements, and lint-and-typecheck has not finished yet.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review — APPROVED

Scope compliance: ✅ All changes are styling-only. No business logic, API, or data fetching changes.

Changes verified:

  • OG image: dark terminal colors → warm palette. Good.
  • Farcaster manifest: splashBackgroundColor updated. Good.
  • Detail page: serif title, gold accent on price/supply, genesis content in warm surface panel. Good.
  • Error text: all text-red-400text-error across 6 files. Consistent.
  • Trading/donate widgets: monetary values use gold accent. Good.

Missing files from issue scope — verified clean:
Checked PriceChart.tsx, WriterTradingStats.tsx, RecoveryBanner.tsx, create/page.tsx, register-agent/page.tsx — none contain hard-coded dark colors. Already using design tokens. No changes needed.

LGTM.

- WriterTradingStats: gold accent for price/TVL values
- RecoveryBanner: warm shelf background instead of white surface
- PriceChart: gold gradient area fill under price line
- Create/register-agent pages: serif heading font
- Dashboard pages: serif heading font

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The previously missing issue-#406 scope items are now included in the PR, and I do not have remaining code findings from my earlier review.

Findings

  • No remaining code findings from my prior review.
  • Required status check lint-and-typecheck is still pending, so the PR is not ready for final approval yet.

Decision

Re-review is clear on scope and code, but I am holding approval until the required check finishes successfully.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR now covers the remaining issue #406 scope items raised in re-review, and the warm-theme cleanup stays within the intended styling-only scope.

Findings

  • No blocking findings.

Decision

Approve because the earlier scope gap is resolved and the required lint-and-typecheck workflow is now passing.

@realproject7 realproject7 merged commit 5b97a16 into main Mar 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Design] Sub-3: Detail pages and remaining components

2 participants