Skip to content

[#417] Ruled notebook paper on story detail content#419

Merged
realproject7 merged 1 commit intomainfrom
task/417-ruled-paper-content
Mar 21, 2026
Merged

[#417] Ruled notebook paper on story detail content#419
realproject7 merged 1 commit intomainfrom
task/417-ruled-paper-content

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Ruled paper CSS: Added .ruled-paper class with light blue horizontal ruled lines and subtle pink left margin line
  • CSS variables: --paper-line, --paper-margin, --paper-bg in globals.css
  • Applied to: Genesis content area and individual plot content pages
  • Responsive: Reduced padding on mobile (2.5rem left vs 4.5rem desktop)
  • Replaces: Previous noise PNG + inset box-shadow paper texture on content areas

Fixes #417

Test plan

  • Plot content area shows ruled notebook paper lines
  • Pink margin line visible on left side
  • Text aligns closely with ruled lines
  • Lines are subtle, text readability not impacted
  • Mobile: padding adapts, lines still look good
  • Individual chapter pages also have ruled paper
  • npm run typecheck passes
  • npm run lint passes

🤖 Generated with Claude Code

- Add CSS variables --paper-line, --paper-margin, --paper-bg to globals.css
- Add .ruled-paper class with blue horizontal lines, pink left margin line
- Apply ruled paper to genesis content and individual plot content areas
- Responsive padding: reduced on mobile for readability
- Replace previous noise PNG + inset shadow paper texture

Fixes #417

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The PR matches the requested scope for issue #417 from the diff I reviewed, and I do not have code findings to raise.

Findings

  • [medium] lint-and-typecheck is still pending, so the PR does not yet satisfy the review checklist requirement that the build passes.
    • File: GitHub Actions / lint-and-typecheck
    • Suggestion: Re-route for final approval once the required check completes successfully.

Decision

Holding approval until CI is green. I can re-review immediately once lint-and-typecheck passes.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review — APPROVED

All requirements from #417 verified:

  1. CSS variables: --paper-line (light blue hsl(234,62%,86%)), --paper-margin (pink hsl(350,100%,91%)), --paper-bg (warm grey hsl(0,15%,95%)) ✅
  2. Ruled lines: repeating-linear-gradient at 1.6em intervals matches line-height: 1.6 — text aligns with ruled lines ✅
  3. Margin line: Pink vertical line via linear-gradient(90deg, ...) at left padding boundary ✅
  4. Applied to: Genesis content area + individual plot content pages ✅
  5. Replaces: Removed noise PNG base64 + inset box-shadow from genesis section ✅
  6. Responsive: Mobile breakpoint at 640px reduces left padding (4.5rem → 2.5rem) and adjusts margin line position accordingly ✅
  7. Scope: No changes to home page, StoryCard, or business logic ✅

The three-layer background-image stack is well-crafted: margin line → top header blank → ruled lines. Font size changes from text-sm (0.875rem) to 1rem to match the ruled line spacing — acceptable trade-off for alignment.

3 files changed, tightly scoped. Ship it.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

Re-review complete. The PR matches issue #417 scope, and the required lint-and-typecheck check is now passing.

Findings

  • No blocking findings.

Decision

Approved.

@realproject7 realproject7 merged commit 5477acb into main Mar 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Design] Option 3 Sub-2: Ruled paper content area on story detail

2 participants