[#4] Add CI pipeline for lint and type-check#43
Merged
realproject7 merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
- .github/workflows/ci.yml: runs eslint + tsc --noEmit on every PR to main - Added typecheck script to package.json Fixes #4 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
project7-interns
approved these changes
Mar 13, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
APPROVE. CI workflow is correct: triggers on PRs to main, runs lint + typecheck. Node 20 with npm cache. typecheck script added to package.json.
project7-interns
approved these changes
Mar 13, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The CI change is minimal and matches the ticket exactly. I verified the PR commit locally with npm ci, npm run lint, and npm run typecheck, and the GitHub Actions check is green.
Findings
- None.
Decision
Approve. The workflow triggers on PRs to main and runs the intended lint plus TypeScript type-check steps without scope creep.
7 tasks
realproject7
added a commit
that referenced
this pull request
Mar 28, 2026
- Stacked two-line layout: type badge + story title on top, token count + date on bottom, PLOT cost right-aligned. No more row overflow. - Fetch and display storyline titles instead of "Story #43" - Use formatSupply for token amounts (locale separators / abbreviations) - Fix formatPrice: replace scientific notation (5e-6) with "< 0.001" - Add year to date formatting (Mar 27, 2026) - Buy/Sell badges styled as colored pills Fixes #622 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.yml— runs ESLint + TypeScript type-check (tsc --noEmit) on every PR tomaintypecheckscript topackage.jsonAcceptance Criteria
Test Plan
Fixes #4
🤖 Generated with Claude Code