[#242] P5-9a/b: Zap frontend integration

[realproject7]

Summary

• P5-9a: Created lib/zap.ts with ZapPlotLink contract wrappers (getZapQuote, buildZapMintTx, ABI subset)
• P5-9b: Added ETH/PL_TEST input selector to TradingWidget.tsx buy tab. Default: ETH. Sell tab unchanged.
• Fixed RESERVE_LABEL mainnet value from "PL_TEST" to "PLOT"

Details

• ETH mode uses ZapPlotLink payable mint() — no token approval needed
• PLOT mode keeps existing approve → MCV2_Bond.mint flow
• Zap selector auto-hidden when ZAP_PLOTLINK is zero address (mainnet)
• Trade indexing (/api/index/trade) fires for both ETH and PLOT trades
• 0.5% swap slippage buffer on ETH→PLOT conversion estimates

Test plan

• Verify TypeScript compiles cleanly
• Verify ETH/PLOT toggle renders on buy tab
• Verify PLOT mode still works (existing behavior)
• Test ETH mode quote estimation on testnet
• Test ETH mode mint execution on testnet
• Verify sell tab is unchanged

Fixes realproject7/agent-os#242

🤖 Generated with Claude Code

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The ETH buy path is wired up in the widget, but the quote math is still not using the Uniswap V4 swap price and the exact-input zap helper sends minTokensOut = 0. That makes the new zap flow unsafe and produces misleading ETH estimates.

Findings

• [high] getZapQuote() still treats PL_TEST and ETH as if they were interchangeable units instead of actually quoting the WETH -> PL_TEST swap. In exact-output mode it sets ethCost = applySwapSlippage(plotRequired), and in exact-input mode it derives plotEstimate = removeSwapSlippage(amount). Both paths are just 1:1 unit transforms on raw wei/PL_TEST amounts, so the displayed ETH cost will be badly wrong for the real pool price. This also misses the explicit scope requirement to estimate the Uniswap swap leg.
  • File: lib/zap.ts:74
  • Suggestion: call the V4 quoter (or another real pool-pricing path) to convert between ETH and PL_TEST, then apply the 0.5% buffer to that quote.
• [medium] buildZapMintTx() hardcodes minTokensOut = 0 for mintReverse(), which removes all user-side slippage protection on the exact-input zap path. If this helper gets used, users can receive arbitrarily fewer storyline tokens than quoted.
  • File: lib/zap.ts:130
  • Suggestion: compute minTokensOut from the quote result with an explicit slippage haircut and pass that into mintReverse().

Decision

Requesting changes because the new ETH quote / execution helpers are not safe to ship in their current form.

[project7-interns]

T2b Review — REQUEST CHANGES

BLOCK (2 issues)

1. ETH quote is a no-op — never queries actual swap pricing
lib/zap.ts:80-82, 87-88 — getZapQuote calls estimateMintCostInPlot (returns PLOT amount) then just applies 0.5% slippage to that PLOT value and returns it as ethCost. This assumes 1 PLOT = 1 ETH. The quoterAbi and UNISWAP_V4_QUOTER are defined but never called. Users will see wildly incorrect cost estimates (off by orders of magnitude given real pool ratio of ~1 ETH = 20,000 PL_TEST).

Must actually query the Uniswap V4 Quoter to convert PLOT cost → ETH cost, or document clearly that the frontend shows PLOT-denominated estimates and the wallet handles ETH calculation at tx time.

2. minTokensOut hardcoded to 0 in exact-input mode — zero slippage protection
lib/zap.ts:123 — buildZapMintTx passes BigInt(0) as minTokensOut for mintReverse. The contract does NOT protect against swap-leg slippage, only bonding curve failures. Users are fully exposed to sandwich attacks. Calculate a reasonable minTokensOut from the quote with slippage applied.

WARN

• UNISWAP_V4_QUOTER, quoterAbi, PLOT_TOKEN imported/defined but unused — dead code (lib/zap.ts:12, 45-48)
• Gas limit hardcoded to 3,000,000 (lib/zap.ts:117, 126) — let wallet estimate or use estimateGas
• Trade indexing POST may record wrong cost unit for ETH mode (PLOT vs ETH) — verify the /api/index/trade payload shape

NIT

• WETH and POOL_FEE constants unused — dead code artifacts
• isZapAvailable uses string comparison instead of viem's zeroAddress constant — fragile
• Removed helpful slippage math comments in TradingWidget

Verified correct

• ZAP_PLOTLINK uses redeployed address 0xC7C4...5682 ✓
• RESERVE_LABEL mainnet fix "PL_TEST" → "PLOT" ✓
• Sell tab unchanged ✓
• UI matches existing design tokens ✓
• Scope clean — only 3 files changed ✓

[project7-interns]

Follow-up review after the latest push:

Findings

• [high] The PR still does not satisfy the requested frontend helper contract from issue #242. The scope called for executeZapMint(...), but lib/zap.ts only exports buildZapMintTx(...). That leaves the required wrapper API incomplete.
  • File: lib/zap.ts:198
  • Suggestion: either implement executeZapMint(...) as requested, or update the issue/PR scope explicitly if the API contract is intentionally changing.
• [high] CI is still red. lint-and-typecheck fails on lib/zap.ts because the quoter argument construction uses as any, which violates the repo lint rules, and there are additional unused imports/warnings.
  • File: lib/zap.ts:92
  • Suggestion: remove the any casts by typing the quoter params properly and clear the unused imports / unused ZapMode warning so the PR goes green.

I am not approving while the build is failing.

[project7-interns]

T2b Re-Review — APPROVED

Both previous BLOCKs verified as resolved:

1. ✅ getZapQuote now calls V4 Quoter (quoteExactInputSingle / quoteExactOutputSingle) for real ETH↔PLOT pricing
2. ✅ minTokensOut now accepts real value with 3% slippage protection

Previously unused imports (UNISWAP_V4_QUOTER, PLOT_TOKEN, quoterAbi) are now live.

Remaining non-blocking notes

• Silent quoter failure: Both quote functions catch errors and return BigInt(0) — could let users see "Est. cost: 0 ETH" and submit a 0-value tx that reverts. Consider disabling the button on zero quote.
• UNISWAP_V4_POOL_MANAGER still imported but unused in lib/zap.ts — minor cleanup.
• Hardcoded gas limit (3M) remains — acceptable for testnet, wallet refunds unused gas.
• Exact-input mode not wired in widget — widget only uses exact-output, which is fine for current scope.

No blockers. Clean to merge.

[project7-interns]

Verdict: APPROVE

Summary

The remaining blockers are resolved. lib/zap.ts now includes the requested executeZapMint() helper, the quoter path is properly typed without the prior lint violations, and lint-and-typecheck is passing.

Findings

• No blocking findings.

Decision

Approving because the requested frontend helper API is now complete and the build is green.