Skip to content

Update ZAP_PLOTLINK to fixed routing contract#444

Merged
realproject7 merged 1 commit intomainfrom
task/442-fix-zap-routing
Mar 23, 2026
Merged

Update ZAP_PLOTLINK to fixed routing contract#444
realproject7 merged 1 commit intomainfrom
task/442-fix-zap-routing

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Update ZAP_PLOTLINK mainnet address to 0x7bC192848003ab1Ba286C66AFD0dd8a1729c6b02 (new contract with fixed HUNT/USDC routing)

Fixes #443

Test plan

  • Constant updated in lib/contracts/constants.ts
  • Frontend quote and mint flows work with new contract address

🤖 Generated with Claude Code

New address: 0x7bC192848003ab1Ba286C66AFD0dd8a1729c6b02
- HUNT now routes via MCV2 bonding curve (no Uniswap)
- USDC now routes via WETH multi-hop (USDC→ETH→PLOT)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@project7-interns project7-interns self-requested a review March 23, 2026 06:05
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review: plotlink PR #444

APPROVE

  • Correct address (0x7bC192848003ab1Ba286C66AFD0dd8a1729c6b02) matches deployed contract
  • Only mainnet constant changed, testnet untouched
  • Single file, 1-line change — clean and minimal
  • Address format is valid checksummed EIP-55

No issues found.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

This constant update is mechanically correct relative to the current deploy note, but it is pointing the frontend at a contract deployment that is not ready to merge yet. The linked contract PR still has blocking review issues, so this address should not be finalized here yet.

Findings

  • [high] ZAP_PLOTLINK is being switched to the deployment from plotlink-contracts PR #60 before that contract PR is approved. Since PR #60 still has blocking issues (failed required check and unresolved routing/pool mismatch), merging this constant now would bake in an address that may change on redeploy.
    • File: lib/contracts/constants.ts:40
    • Suggestion: Hold this PR until the contract PR is fixed and the final approved mainnet deployment address is known, then update the constant to that final address.

Decision

Requesting changes because this PR depends on an unresolved contract deployment and should be updated only after the contract PR is corrected and finalized.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

This frontend PR is now aligned with the latest approved contract deployment state. The constant update is minimal and the checks are green.

Findings

  • [resolved] Dependency on unresolved contract deployment is gone.
    • File: lib/contracts/constants.ts:40
    • Suggestion: None. The PR now points at the finalized approved deployment address.

Decision

Approving because the change is correct and appropriately scoped.

@realproject7 realproject7 merged commit 0adaef4 into main Mar 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[#442] Update frontend for redeployed ZapPlotLinkV2

2 participants