Skip to content

Add PLOT Token Page (/token)#451

Merged
realproject7 merged 3 commits intomainfrom
task/448-token-page
Mar 23, 2026
Merged

Add PLOT Token Page (/token)#451
realproject7 merged 3 commits intomainfrom
task/448-token-page

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • New /token page with PLOT token overview, utility, information, and how-to sections
  • Wallet balance display (connected state)
  • Token utility: reserve token for story tokens, TVL growth, creator royalties
  • How to get PLOT: Mint Club, sell story tokens, Zap
  • Token info: total supply, network, contract address with copy button
  • External links: Mint Club, Hunt Town, BaseScan (placeholder URLs until real $PLOT)

Fixes #256

Test plan

  • next build passes
  • /token route renders
  • Visual: sections display correctly on mobile
  • Wallet balance loads when connected

🤖 Generated with Claude Code

- Hero section with wallet balance
- Token utility: reserve token, TVL growth, creator royalties
- How to get PLOT: Mint Club, sell story tokens, Zap
- Token information: total supply, network, contract address
- Links to Mint Club, Hunt Town, BaseScan
- Copy contract address button
- Mobile responsive, matches Moleskine design

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@project7-interns project7-interns self-requested a review March 23, 2026 09:58
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The page structure is reasonable, but there is at least one concrete code-quality issue in the new file that should be fixed before merge.

Findings

  • [high] MCV2_BOND is imported but never used in the new page. In this repo that is likely to trip lint/typecheck and should be removed before merge.
    • File: src/app/token/page.tsx:8
    • Suggestion: Drop the unused MCV2_BOND import or use it for a real displayed value if that was intended.

Decision

Requesting changes because the PR introduces an avoidable unused import and current checks are not green yet.

realproject7 and others added 2 commits March 23, 2026 10:00
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The blocking issue I raised has been fixed, and the follow-up changes also correct the royalty wording. If CI is green, this is ready to merge from my side.

Findings

  • [resolved] Unused import removed.
    • File: src/app/token/page.tsx:4
    • Suggestion: None.

Decision

Approving because the requested fix is in place and the page content is now cleaner and more accurate.

@realproject7 realproject7 merged commit 4914199 into main Mar 23, 2026
2 checks passed
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The token page is well-structured and the royalty fix (5% -> 1%) in the second commit is correct. However, T2a's finding about the unused import remains unfixed, and I have one additional finding.

Findings

  • [high] Unused MCV2_BOND import — still present (agrees with T2a)

    • File: src/app/token/page.tsx:7
    • The second commit (3a72559) only fixed the royalty text; it did NOT remove the unused MCV2_BOND import. This will fail lint (no-unused-vars / TypeScript noUnusedLocals). CI lint-and-typecheck is still pending — expect it to fail.
    • Fix: Change line 7 from PLOT_TOKEN, MCV2_BOND, EXPLORER_URL, to PLOT_TOKEN, EXPLORER_URL,
  • [low] Empty catch block in handleCopyAddress

    • File: src/app/token/page.tsx:39
    • catch {} silently swallows clipboard errors. Minor, but consider at minimum a console.warn or a user-facing fallback (e.g., set a "Failed to copy" state). Not blocking, but worth addressing.

What looks good

  • Royalty percentage is now correct: "1% mint and 1% burn" (fixed in second commit).
  • Token info (PLOT_TOKEN address, EXPLORER_URL, Base Mainnet) all pull from the shared constants.ts — no hardcoded addresses or secrets.
  • External links (Mint Club, Hunt Town, BaseScan) are reasonable placeholders.
  • Wallet balance read via wagmi useReadContract with proper enabled guard — correct pattern.
  • TradingWidget.tsx tooltip change (removed specific "5%" reference) is consistent with the royalty fix.
  • Mobile-responsive layout with Tailwind classes looks solid.

Decision

Requesting changes for the unused import (high). The empty catch is non-blocking but worth a quick fix while you're at it.

@T2A's finding confirmed — MCV2_BOND import was NOT fixed in the follow-up commit.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review: PR #451 — PLOT Token Page

ISSUES

1. [HIGH] Unused MCV2_BOND import still present

src/app/token/page.tsx:7 imports MCV2_BOND but it's never referenced. Will likely fail lint/typecheck CI. Remove the import.

2. [LOW] Empty catch {} in handleCopyAddress

Silently swallows clipboard errors. Non-blocking but a console.warn or user fallback would be better.

VERIFIED CORRECT

  • Royalty: "1% mint and 1% burn" ✅
  • TradingWidget tooltip updated consistently
  • Addresses from constants, no hardcoded secrets
  • Wallet balance uses proper wagmi hooks
  • Layout clean and responsive

VERDICT: REQUEST CHANGES — Remove unused import.

@realproject7 realproject7 mentioned this pull request Mar 23, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants