Skip to content

Switch system font to Lora (revertible)#455

Merged
realproject7 merged 1 commit intomainfrom
task/450-lora-font
Mar 23, 2026
Merged

Switch system font to Lora (revertible)#455
realproject7 merged 1 commit intomainfrom
task/450-lora-font

Conversation

@realproject7
Copy link
Copy Markdown
Owner

@realproject7 realproject7 commented Mar 23, 2026

Summary

  • Switch body and heading font from Geist Mono to Lora (serif)
  • Geist Mono retained for code/pre/monospace elements (addresses, contract data)
  • Ruled paper line-height adjusted from 26px to 28px for better serif alignment

Fixes #450

Revert Point

git reset --hard 47c5df7258e1d2ba34c934f5a72feb66356ed4cd

Test plan

  • next build passes
  • Visual: Lora renders on all pages
  • Visual: Ruled paper lines align with text
  • Visual: Code/address elements still use monospace
  • Mobile responsive

🤖 Generated with Claude Code

Revert point: 47c5df7

Changes:
- Import Lora from Google Fonts alongside Geist Mono
- Body and headings now use Lora (serif)
- Geist Mono retained for code, pre, .font-mono elements
- Ruled paper line-height adjusted from 26px to 28px for serif

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@project7-interns project7-interns self-requested a review March 23, 2026 10:29
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review: PR #455 — Switch Font to Lora

APPROVED

  • Lora properly imported via next/font/google with CSS variable --font-lora
  • Solid fallback chain: "Lora", Georgia, "Times New Roman", serif
  • Monospace carve-out for code, pre, .font-mono correctly retains Geist Mono
  • Line-height adjusted (26px → 28px) for serif metrics
  • Revert point (47c5df7) documented in commit message
  • No unrelated changes

Note: PR body says Fixes #258 but should be Fixes #450 — commit message correctly references [#450]. May want to update PR body so the right issue auto-closes.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The font change is correctly scoped and keeps monospace treatment for code and contract-style data while switching body and heading typography to Lora.

Findings

  • No blocking findings.

Decision

Approving because the implementation is minimal, the PR body now points at the correct issue (Fixes #450), and both required checks are passing.

@realproject7 realproject7 merged commit bf34c15 into main Mar 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Design] Switch system font to Lora (revertible)

2 participants