Skip to content

[#472] Add logo symbol to NavBar, Lora bold brand text#473

Merged
realproject7 merged 1 commit intomainfrom
task/472-branding-update
Mar 23, 2026
Merged

[#472] Add logo symbol to NavBar, Lora bold brand text#473
realproject7 merged 1 commit intomainfrom
task/472-branding-update

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Added plotlink-logo-symbol.svg before "PlotLink" text in NavBar
  • Changed brand text to Lora bold via font-heading font-bold
  • Verified favicon, OG image, and Farcaster manifest references are correct

Test plan

  • Build passes
  • favicon.png (512x512), icon.png (1024x1024), og-image.png correctly referenced in layout.tsx
  • Farcaster manifest iconUrl, splashImageUrl, ogImageUrl point to correct assets
  • Visual check: logo + text don't overflow on mobile

Fixes #472

🤖 Generated with Claude Code

- Add plotlink-logo-symbol.svg before "PlotLink" text in NavBar
- Change brand text to font-heading (Lora) bold
- Verified: favicon.png, icon.png, og-image.png already correctly
  referenced in layout.tsx metadata and farcaster.json manifest

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The branding change is minimal and matches the requested scope: prepend the logo symbol in the NavBar and apply the heading font styling to the brand text. I did not find correctness, security, or scope issues in the diff provided.

Findings

  • None.

Decision

Approve. The PR is narrowly scoped to the NavBar branding update, and the metadata/asset verification called out in the PR description does not conflict with the code change shown.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE

Clean, minimal branding update.

  • Logo SVG correctly placed before brand text with flex items-center gap-1.5
  • Font correctly uses font-heading font-bold → resolves to Lora bold via theme
  • alt="" is correct (decorative image, adjacent text provides accessible name)
  • Favicon/OG/Farcaster manifest references unchanged and valid

Non-blocking suggestion: align Image height={24} prop with CSS h-5 (20px) for readability — functionally harmless for SVGs but slightly confusing.

@realproject7 realproject7 merged commit 4596d61 into main Mar 23, 2026
3 checks passed
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The NavBar branding update itself looks fine, but the ticket’s favicon/icon acceptance criteria are still unmet.

Findings

  • [medium] The metadata still points at asset files that do not match the sizes required by issue #472.
    • File: src/app/layout.tsx:25
    • Suggestion: Replace public/favicon.png with a 32x32 or 48x48 asset and public/icon.png with a 192x192 or 512x512 asset, or add correctly sized derivatives and update the metadata to reference those files.
    • Evidence: public/favicon.png is 512x512 and public/icon.png is 1024x1024 at the PR head.

Decision

Requesting changes because the PR closes #472, but one of that issue’s explicit acceptance checks remains unsatisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Design] Update branding — new logo, favicon, OG image

2 participants