Skip to content

[#481] Complete metadata — icons, OG, Apple, Android, manifest#483

Merged
realproject7 merged 3 commits intomainfrom
task/481-metadata
Mar 24, 2026
Merged

[#481] Complete metadata — icons, OG, Apple, Android, manifest#483
realproject7 merged 3 commits intomainfrom
task/481-metadata

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Expands metadata in layout.tsx with full OG tags (title, description, url, siteName, type), Twitter/X card, Apple web app meta, SVG favicon, and apple-touch-icon
  • Creates public/manifest.json for PWA/Android with app name, icons, theme color, and standalone display
  • Theme color set to #E8DFD0 (matches --bg)

Fixes #481

Test plan

  • Build passes (next build)
  • OG tags render correctly (Facebook Sharing Debugger)
  • Twitter/X card renders (X Card Validator)
  • Apple touch icon shows on iOS home screen
  • manifest.json loads and PWA install prompt works on Android
  • SVG favicon renders in supporting browsers

🤖 Generated with Claude Code

…d, manifest

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Mar 24, 2026 8:00am

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Metadata is comprehensive — OG, Twitter card, Apple web app, manifest all look correct. Assets verified present. One minor note: other: { "theme-color": themeColor } works but Next.js Metadata has a native themeColor field that would be slightly cleaner. Non-blocking — approve as-is.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The metadata additions are close, but the manifest does not provide the Android/PWA icon sizes the issue explicitly requires.

Findings

  • medium public/manifest.json:4 declares 512x512 and 1024x1024 icons, but issue #481 requires Android/PWA icons at 192x192 and 512x512. Without a 192x192 entry, install surfaces that expect the standard launcher icon size may not pick an appropriate asset.
    • File: public/manifest.json:4
    • Suggestion: add a real 192x192 icon asset plus a matching manifest entry, and keep the 512x512 icon entry.

Decision

Request changes because the PR does not yet satisfy the manifest/icon acceptance criteria for #481.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The follow-up revision resolves the manifest gap by adding a real 192x192 Android/PWA icon and wiring it into manifest.json. The rest of the metadata changes remain aligned with the issue requirements.

Findings

  • None.

Decision

Approve because the previously requested manifest/icon fix is now present and #481's metadata acceptance criteria are satisfied.

@realproject7 realproject7 merged commit 4c1e36a into main Mar 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UX] Complete metadata — favicon, icons, OG, Apple, Android, X, Facebook

2 participants