[#488] Add Share to X, Farcaster, and Copy Link buttons#494
[#488] Add Share to X, Farcaster, and Copy Link buttons#494realproject7 merged 2 commits intomainfrom
Conversation
Replace single ShareToFarcaster button with three-button share group: - Share to X (Twitter intent URL) - Farcaster (SDK composeCast in-app, farcaster.com intent on web) - Copy Link (clipboard with confirmation toast) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Clean component — three buttons with consistent styling, proper platform detection. X uses intent URL with text-embedded link, Farcaster uses SDK composeCast in-app with intent fallback on web, Copy Link has clipboard API with 2s confirmation. SVG icons are clean. Old ShareToFarcaster correctly replaced in both mobile and desktop sidebar slots. No issues.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The share-button behavior looks reasonable, but the component placement does not match the ticket: on desktop the buttons are still in the sidebar instead of below the chapters section.
Findings
- medium
src/app/story/[storylineId]/page.tsx:185rendersShareButtonsinside the desktop sidebar, while issue #488 explicitly asks for the three buttons to be added "below the chapters section." The current PR only places them below the chapters on mobile; desktop users still see the controls detached from the story content in the aside.- File:
src/app/story/[storylineId]/page.tsx:185 - Suggestion: render the share group in the main content flow beneath the chapter list/comments for all breakpoints, rather than only in the desktop sidebar.
- File:
Decision
Request changes because the PR does not place the share controls where #488 specifies on desktop.
Remove share from desktop sidebar and show in main story flow beneath chapter list on all screen sizes per review feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up revision moves the share group into the main story flow below the chapters and removes the duplicate sidebar placement on desktop. The three-button share behavior remains aligned with the issue requirements.
Findings
- None.
Decision
Approve because the previously requested placement fix is now in place and #488 is ready from a code review perspective.
2 participants
Summary
ShareButtonscomponent with three share options in a row: Share to X, Farcaster, Copy LinkcomposeCast()when in Farcaster client, falls back to farcaster.com intent URL on webShareToFarcasterusage in story page (both mobile and desktop sidebar)border-border bg-surfacepattern)Fixes #488
Test plan
next build)🤖 Generated with Claude Code