Skip to content

[#512] Fix profile activity feed layout on mobile#515

Merged
realproject7 merged 2 commits intomainfrom
task/512-mobile-activity-feed
Mar 24, 2026
Merged

[#512] Fix profile activity feed layout on mobile#515
realproject7 merged 2 commits intomainfrom
task/512-mobile-activity-feed

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • FeedRow stacks into two rows on mobile: event type + story title on row 1, detail (amount) + date + tx link on row 2
  • Stays horizontal single-row on sm+ screens (unchanged desktop behavior)
  • Fixes: story titles no longer truncated to 1-2 chars, amounts don't overlap dates, "PLOT" no longer merges with date text
  • Moved entry.detail next to the date on a separate line so both have room to breathe

Fixes #512

Test plan

  • View profile page on mobile viewport (< 640px) — verify two-row layout
  • Verify story title has room to display (not truncated to 1-2 chars)
  • Verify amount ("12.5 PLOT") and date ("Mar 20") are clearly separated
  • View on desktop (640px+) — verify single-row layout unchanged
  • Test with long story titles and large amounts

🤖 Generated with Claude Code

Stack FeedRow into two rows on mobile (title on row 1, detail + date
on row 2) to prevent text overflow, title truncation, and "PLOT"
merging with dates. Stays horizontal on sm+ screens.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Mar 24, 2026 8:31pm

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The row split helps, but the mobile fix still leaves long trade-detail strings able to overflow on narrow screens.

Findings

  • [medium] The second row is still forced onto a single non-wrapping line, so large entry.detail values can still break the mobile layout instead of remaining readable.
    • File: src/app/profile/[address]/page.tsx:1100
    • Suggestion: Let the second row wrap on mobile, or allow the detail segment to shrink/wrap instead of combining shrink-0 on the row container with whitespace-nowrap on both the detail and date.
    • Why: issue #512 explicitly calls out large token amounts, and a value like 1089000.00 tokens for 2178.00 PLOT plus the date and tx link can still exceed narrow mobile widths.

Decision

Requesting changes because the current patch improves separation but does not fully satisfy the acceptance criterion that large token amounts remain readable on mobile.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean mobile fix. flex-col/sm:flex-row split is the right pattern. pl-18 aligns row 2 under the story title (past w-16 label + gap-2 = 4.5rem). whitespace-nowrap on detail and date prevents the merging issue. LGTM.

Remove shrink-0 and whitespace-nowrap from the detail/date row so
large values like "1089000.00 tokens for 2178.00 PLOT" can wrap
instead of overflowing on narrow screens.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The updated FeedRow now lets long detail strings wrap on mobile while preserving the intended two-row mobile layout and the single-row desktop layout.

Findings

  • No outstanding findings in the updated diff.

Decision

Approve. The current PR head addresses the overflow issue from my prior review and satisfies issue #512's mobile readability requirement. I did not render the page locally.

@realproject7 realproject7 merged commit f59b3f9 into main Mar 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix profile activity feed layout on mobile — text overflow and truncation

2 participants