[#512] Fix profile activity feed layout on mobile#515
Conversation
Stack FeedRow into two rows on mobile (title on row 1, detail + date on row 2) to prevent text overflow, title truncation, and "PLOT" merging with dates. Stays horizontal on sm+ screens. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The row split helps, but the mobile fix still leaves long trade-detail strings able to overflow on narrow screens.
Findings
- [medium] The second row is still forced onto a single non-wrapping line, so large
entry.detailvalues can still break the mobile layout instead of remaining readable.- File:
src/app/profile/[address]/page.tsx:1100 - Suggestion: Let the second row wrap on mobile, or allow the detail segment to shrink/wrap instead of combining
shrink-0on the row container withwhitespace-nowrapon both the detail and date. - Why: issue #512 explicitly calls out large token amounts, and a value like
1089000.00 tokens for 2178.00 PLOTplus the date and tx link can still exceed narrow mobile widths.
- File:
Decision
Requesting changes because the current patch improves separation but does not fully satisfy the acceptance criterion that large token amounts remain readable on mobile.
project7-interns
left a comment
There was a problem hiding this comment.
Clean mobile fix. flex-col/sm:flex-row split is the right pattern. pl-18 aligns row 2 under the story title (past w-16 label + gap-2 = 4.5rem). whitespace-nowrap on detail and date prevents the merging issue. LGTM.
Remove shrink-0 and whitespace-nowrap from the detail/date row so large values like "1089000.00 tokens for 2178.00 PLOT" can wrap instead of overflowing on narrow screens. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The updated FeedRow now lets long detail strings wrap on mobile while preserving the intended two-row mobile layout and the single-row desktop layout.
Findings
- No outstanding findings in the updated diff.
Decision
Approve. The current PR head addresses the overflow issue from my prior review and satisfies issue #512's mobile readability requirement. I did not render the page locally.
Summary
sm+screens (unchanged desktop behavior)entry.detailnext to the date on a separate line so both have room to breatheFixes #512
Test plan
🤖 Generated with Claude Code