[#518] Fix home page story card layout#523
Conversation
- Move author name inside moleskine cover (bottom area, no nested links) - Move plot count inside as compact badge next to genre tag - Move NEW indicator inside cover as badge - Reduce metadata below card to only TVL and rating - Bump version to 0.1.2 Fixes #518 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
APPROVE — clean restructure. Good call using linkProfile={false} to avoid nested inside the wrapper. Badge layout with flex-wrap handles multiple badges well. Metadata section below the card is now lean. No issues found.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The layout cleanup is directionally right, but the current implementation regresses author navigation and misses an explicit acceptance criterion from issue #518.
Findings
- [medium] The author name is no longer clickable after being moved back inside the notebook.
- File:
src/components/StoryCard.tsx:102 - Suggestion: preserve a clickable profile target inside the card without nesting anchors. For example, restructure the card wrapper so the author can remain an interactive element, or handle card navigation without wrapping the entire card in a
<Link>.
- File:
Decision
Requesting changes because issue #518 requires the author to be displayed inside the moleskine and still be clickable to profile, but linkProfile={false} disables the only link path in WriterIdentityClient.
Restructured card to avoid nested <a> tags:
- Card wrapper changed from <Link> to <div> with a stretched <Link> overlay (z-30)
- Author section at z-40 so WriterIdentityClient profile link is clickable above the overlay
- Re-enabled linkProfile={true} (default) on WriterIdentityClient
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Re-reviewed after fix. APPROVE — stretched link pattern (z-30 card overlay + z-40 author) cleanly solves the nested anchor issue while keeping the author profile link clickable. Good aria-label on the overlay for accessibility.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The stretched-link restructure fixes the nested-anchor problem, but the author link target still does not match issue #518.
Findings
- [medium] The author is clickable again, but it still links to Farcaster instead of the app profile route described in the issue.
- File: src/components/StoryCard.tsx:115
- Suggestion: link the in-card author name to /profile/[address] instead of relying on WriterIdentityClient's external Farcaster link.
Decision
Requesting changes because issue #518 explicitly calls for the author to remain clickable as a link to /profile, and the current implementation still renders the external link path from src/components/WriterIdentityClient.tsx:46-53.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I re-checked the actual PR-head files on GitHub. The stretched-link structure restores full-card navigation, and the in-card author link remains clickable to the internal profile route.
Findings
- None.
Decision
Approving because the current head satisfies issue #518: author is inside the moleskine and clickable to /profile/[address], plot count is inside as a compact badge, the bottom section is reduced, and genre placement is preserved.
Update StoryCard tests to match new card structure:
- Use getByRole('link') instead of closest('a') for story link test
- Use closest('.moleskine-notebook') for class test
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 participants
Summary
linkProfile={false}to avoid nested<a>tags2 plots)0.1.2Test plan
Fixes #518
🤖 Generated with Claude Code