Skip to content

[#519] Add version number to footer#524

Merged
realproject7 merged 1 commit intomainfrom
task/519-version-footer
Mar 25, 2026
Merged

[#519] Add version number to footer#524
realproject7 merged 1 commit intomainfrom
task/519-version-footer

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Import version from package.json in the Footer component
  • Display v{version} next to the copyright line (e.g. PlotLink © 2026 · v0.1.3)
  • Bumped version to 0.1.3

Test plan

  • Footer shows version number (e.g. v0.1.3)
  • Version updates when package.json version changes
  • Footer layout unchanged otherwise

Fixes #519

🤖 Generated with Claude Code

- Import version from package.json
- Display v{version} in footer next to copyright
- Bump version to 0.1.3

Fixes #519

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Mar 25, 2026 8:14am

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — minimal and correct. Clean import from package.json, version displayed nicely in footer.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The change is small, but the current JSON import form is not valid for the value being consumed in the footer.

Findings

  • [medium] src/components/Footer.tsx:3 imports version as a named export from ../../package.json, but JSON modules do not provide a named version export.
    • File: src/components/Footer.tsx:3
    • Suggestion: switch to a default import of the JSON object, then read .version from that object.

Decision

Requesting changes because the current code relies on import { version } from "../../package.json", which does not match JSON module export semantics. I verified this separately with Node ESM import behavior, which rejects the named version export.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

I re-checked the exact PR head against the repo config and current GitHub checks. In this project, the footer change is valid and the version displays as intended.

Findings

  • None.

Decision

Approving because the current head satisfies #519: the footer shows the app version, the patch version bump is present, and the repo's PR-head plus passing confirm the JSON import form is accepted in this build setup.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

I re-checked the exact PR head against the repo config and current GitHub checks. In this project, the footer change is valid and the version displays as intended.

Findings

  • None.

Decision

Approving because the current head satisfies issue #519: the footer shows the app version, the patch version bump is present, and the PR-head tsconfig plus passing lint-and-typecheck confirm this JSON import form is accepted in this build setup.

@realproject7 realproject7 merged commit d4c999b into main Mar 25, 2026
5 checks passed
@realproject7 realproject7 deleted the task/519-version-footer branch March 25, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add version number from package.json to footer — match Dropcast pattern

2 participants