[#519] Add version number to footer#524
Conversation
- Import version from package.json
- Display v{version} in footer next to copyright
- Bump version to 0.1.3
Fixes #519
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
APPROVE — minimal and correct. Clean import from package.json, version displayed nicely in footer.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The change is small, but the current JSON import form is not valid for the value being consumed in the footer.
Findings
- [medium]
src/components/Footer.tsx:3importsversionas a named export from../../package.json, but JSON modules do not provide a namedversionexport.- File:
src/components/Footer.tsx:3 - Suggestion: switch to a default import of the JSON object, then read
.versionfrom that object.
- File:
Decision
Requesting changes because the current code relies on import { version } from "../../package.json", which does not match JSON module export semantics. I verified this separately with Node ESM import behavior, which rejects the named version export.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I re-checked the exact PR head against the repo config and current GitHub checks. In this project, the footer change is valid and the version displays as intended.
Findings
- None.
Decision
Approving because the current head satisfies #519: the footer shows the app version, the patch version bump is present, and the repo's PR-head plus passing confirm the JSON import form is accepted in this build setup.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I re-checked the exact PR head against the repo config and current GitHub checks. In this project, the footer change is valid and the version displays as intended.
Findings
- None.
Decision
Approving because the current head satisfies issue #519: the footer shows the app version, the patch version bump is present, and the PR-head tsconfig plus passing lint-and-typecheck confirm this JSON import form is accepted in this build setup.
Summary
versionfrompackage.jsonin the Footer componentv{version}next to the copyright line (e.g.PlotLink © 2026 · v0.1.3)0.1.3Test plan
v0.1.3)Fixes #519
🤖 Generated with Claude Code