[#520] Redesign footer to match Dropcast style#525
Conversation
- Replace 'PlotLink © 2026' with 'v{version} · Base Mainnet · Made by @project7'
- @project7 links to https://farcaster.xyz/project7
- Center-align the version/credits line
- Bump version to 0.1.4
Fixes #520
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
REQUEST CHANGES — one finding:
src/components/Footer.tsx line 41: profile link uses https://farcaster.xyz/project7 but the correct domain is https://farcaster.com/project7 (warpcast.com and farcaster.xyz are deprecated in favor of farcaster.com).
Otherwise the change looks clean — center alignment, version display, and Base Mainnet label are all good.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The version-credit line is updated correctly, but the footer is still not center-aligned as requested in issue #520.
Findings
- [medium] The main footer content still uses a split layout instead of a centered Dropcast-style layout.
- File: src/components/Footer.tsx:12
- Suggestion: remove the remaining /separate right-side layout and center the existing links plus the network text together so the whole footer reads as a centered composition.
Decision
Requesting changes because issue #520 explicitly requires centered footer content, but the current PR head still keeps the upper footer row in a two-column layout with , so the acceptance criteria are not fully met.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
URL fix confirmed — farcaster.com is correct now. My finding is resolved.
Note: I agree with T2a's finding — issue #520 acceptance criteria says 'Center-align all footer content' and 'Content centered', but only the bottom line is centered. The upper section (links, 'built on Base') still uses the split layout. That should be addressed to fully meet the spec.
- Center links row with justify-center - Remove split layout (sm:justify-between) - Remove separate 'built on Base' span (redundant with 'Base Mainnet' in credits) - Add items-center to outer container Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Re-reviewed — full footer is now centered. Split layout removed, links row uses justify-center, redundant 'built on Base' removed (covered by 'Base Mainnet' in credits). Meets all #520 acceptance criteria. APPROVE.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The updated footer now matches issue #520: the footer content is centered, the credits line uses the requested version and network text, and the @project7 link points to the Farcaster profile.
Findings
- None.
Decision
Approving because the current head satisfies the acceptance criteria without introducing scope creep.
Update footer branding test to check for 'Base Mainnet' and '@project7' instead of the removed 'PlotLink' copyright text. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 participants
Summary
PlotLink © 2026withv{version} · Base Mainnet · Made by @project7@project7links tohttps://farcaster.xyz/project70.1.4Test plan
v0.1.4 · Base Mainnet · Made by @project7@project7link opens farcaster.xyz/project7 in new tabFixes #520
🤖 Generated with Claude Code