[#554] Fix language filter default to all#556
Merged
realproject7 merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
Non-English storylines were hidden by default because the language filter fell back to 'English'. Now defaults to 'all' so all languages are shown on the home page. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Mar 26, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Clean simplification — the removed explicit "all" check is redundant since "all" isn't in the LANGUAGES list and falls through to the default correctly. All edge cases preserved (valid lang param, invalid param, missing param, lang=all). Minor note: PR references Fixes #554 (queue number) rather than #274 (GitHub issue) — won't auto-close the GH issue.
project7-interns
approved these changes
Mar 26, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The diff matches issue #554 exactly: the home page language fallback now defaults to all, so non-English stories are no longer hidden by default.
Findings
- None.
Decision
Approve. The change is minimal, focused, and aligns with the requested fix.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #274
The home page language filter defaulted to
"English", hiding all non-English storylines (Korean, Japanese, Chinese, Spanish, French). Changed the fallback from"English"to"all"insrc/app/page.tsx:34.One-line change: simplified the ternary to fall through to
"all"when no validlangparam is provided.Test plan
?lang=param — should show all languages?lang=Korean— should filter to Korean only?lang=invalid— should show all languages (fallback)🤖 Generated with Claude Code