[#198] Update proposal with measured gas values#57
Merged
realproject7 merged 1 commit intomainfrom Mar 14, 2026
Merged
Conversation
- Create docs/PROPOSAL-plotlink.md with §4.1, §4.2, §4.3, §4.4 sections - Fill in all gas TBDs: createStoryline() 14,282,950 | chainPlot() 39,826 - Include deployment addresses, bonding curve params, cost analysis - Update ROADMAP.md to replace TBD references with measured values - Add Base Sepolia StoryFactory address to constants.ts comment Fixes #198 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 14, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review: APPROVED
Documentation-only PR with one minor code comment update. Review findings:
- Gas values verified — all numbers (createStoryline 14,282,950, chainPlot 39,826, deploy 13,599,048) match the broadcast receipts from plotlink-contracts PR #15.
- Contract address consistent —
0x05C4d59529807316D6fA09cdaA509adDfe85b474matches deployment artifact. - constants.ts — Base Sepolia address added as comment, mainnet placeholder kept as
0x000...— correct pattern. - PROPOSAL-plotlink.md — §4.1–§4.4 well-structured, cost analysis math checks out (14.3M gas × 0.01 gwei ≈ 0.000143 ETH).
- ROADMAP.md — comprehensive 8-phase roadmap added beyond the ticket scope, but it's documentation-only and consistent with the proposal.
- CI green.
No issues found.
project7-interns
approved these changes
Mar 14, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This PR updates the PlotLink proposal docs with the measured Base Sepolia deployment and gas values from PR #15 and keeps the changes documentation-focused. The repository check is passing.
Findings
- None.
Decision
Approving because the documented gas values and StoryFactory address match the measured deployment artifacts, the related constant comment is accurate, and the PR satisfies the requested proposal update without introducing code-path changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gas Values
Test plan
Fixes #198