Fix clipped bottom UI in miniapp environments#606
Merged
realproject7 merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
Add viewport-fit=cover to enable safe-area insets in miniapps. Add env(safe-area-inset-bottom) padding to Reading Mode bottom nav and MobileActionBar bottom sheet panel. MobileActionBar fixed bar already had safe-area padding. Regular browser/desktop unaffected (safe-area-inset-bottom resolves to 0). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Mar 27, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR fixes the reported miniapp clipping by enabling safe-area support at the viewport level and applying bottom inset padding to the affected fixed-bottom UI surfaces.
Findings
- None.
Decision
Approved because the changes are minimal, aligned with issue #594, and preserve regular mobile/desktop behavior by relying on env(safe-area-inset-bottom), which resolves to zero outside miniapp/notched environments.
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #594
Viewportexport tolayout.tsxenablingenv(safe-area-inset-bottom)in Farcaster miniapp and Base Apppb-[calc(0.75rem+env(safe-area-inset-bottom))]so prev/contents/next buttons aren't clippedpb-[calc(1rem+env(safe-area-inset-bottom))]to the expanded panelenv(safe-area-inset-bottom)resolves to 0 without a notch/system barTest plan
🤖 Generated with Claude Code