[#638] Fix PLOT-mode MAX buy path and remove unnecessary delays

[realproject7]

Summary

• TradingWidget.tsx: handleBuyMax no longer calls getZapQuote() in PLOT mode (which silently failed). Instead, uses binary search over getReserveForToken on the bonding curve to find the maximum storyline tokens mintable within the user's PLOT balance.
• DonateWidget.tsx: Removed 5-second setTimeout delay before indexer call — unnecessary on Base mainnet.
• usePublish.ts: Removed 5-second setTimeout delay before indexer call — unnecessary on Base mainnet.

Fixes #638
Tracks realproject7/agent-os#309

Test plan

• In PLOT mode, clicking MAX successfully prepares the buy using the bonding-curve quote path
• In non-PLOT mode (ETH/USDC/HUNT), clicking MAX still uses the zap flow as before
• Donate flow proceeds without the extra 5-second delay
• Publish flow proceeds without the extra 5-second delay

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
plotlink	Ignored		Mar 30, 2026 6:19pm

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The PR fixes the silent PLOT-mode failure and removes the artificial waits, but the new PLOT MAX path still does not reliably compute the actual maximum buyable amount.

Findings

• [high] The binary-search upper bound assumes 1 storyline token <= 1 PLOT, which is not guaranteed by the bonding curve.
  • File: src/components/TradingWidget.tsx:185
  • Suggestion: Grow hi until getReserveForToken(tokenAddress, hi) exceeds the user's PLOT balance (for example by doubling from 1 token), then binary-search within that bracket. That keeps MAX correct when the marginal price is below 1 PLOT and the user can mint more than maxBalance token units.

Decision

Requesting changes because the current implementation can still underfill MAX buys in PLOT mode, so it does not meet the acceptance criterion that MAX works correctly.

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The revised multicall search fixes the earlier upper-bound / round-trip issues, but the PLOT-mode MAX path still misses a valid buy range below one full token.

Findings

• [high] The probe ladder starts at 1e18 and returns early when that first whole-token probe is too expensive, so MAX still does nothing for wallets that can afford only a fractional token.
  • File: src/components/TradingWidget.tsx:188
  • Suggestion: Include sub-1-token probes (for example 1e17, 1e16, ...), or fall back to a finer-grained search in (0, 1e18) when the first probe exceeds maxBalance. The widget already accepts 18-decimal token amounts, so MAX needs to cover that range too.

Decision

Requesting changes because users who can buy less than one storyline token still get a broken MAX button, which does not satisfy the acceptance criterion that MAX works correctly in PLOT mode.

[project7-interns]

Verdict: APPROVE

Summary

The requested fixes are addressed. PLOT-mode MAX now uses the bonding-curve path instead of Zap, covers fractional token amounts, and the 5-second waits remain removed from donate and publish.

Findings

• None.

Decision

Approving on code review. lint-and-typecheck is passing; the remaining checks are still running, but they do not block the review verdict.