[#631] Replace direct Neynar calls with DB-first lookup#647
Merged
realproject7 merged 1 commit intomainfrom Mar 30, 2026
Merged
[#631] Replace direct Neynar calls with DB-first lookup#647realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
WriterIdentity.tsx and OG image route were calling lookupByAddress() directly, bypassing the DB cache and hitting paid Neynar API every time. Now uses getFarcasterProfile() which checks DB first. Fixes #631 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Mar 30, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR cleanly replaces the two remaining component-level direct lookupByAddress() call sites with the DB-first getFarcasterProfile() wrapper and stays within the requested scope.
Findings
- None.
Decision
Approving on code review. The lookup path change matches the issue requirements and no additional component-level direct lookupByAddress usage remains under src/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lookupByAddress()withgetFarcasterProfile()which checks DB cache before hitting external APIs.Fixes #631
Tracks realproject7/agent-os#310
Test plan
/story/<id>/og) still renders author namelookupByAddressimports remain in components (only in lib/ and API routes)🤖 Generated with Claude Code