[#632] Fix first-connect race in useConnectedIdentity#648
Merged
realproject7 merged 1 commit intomainfrom Mar 30, 2026
Merged
Conversation
useConnectedIdentity fired register-by-wallet (fire-and-forget) and getFarcasterProfile in parallel, causing double SteemHunt/Neynar API calls on first connect since DB was empty when profile fetch ran. Now awaits register completion before fetching profile, so the DB is populated first and getFarcasterProfile reads from cache. Fixes #632 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Mar 30, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR fixes the first-connect race in useConnectedIdentity by waiting for the register-by-wallet request before running the DB-first profile lookup, and it stays scoped to that issue.
Findings
- None.
Decision
Approving on code review. The async ordering now matches the issue requirements, preserves the non-fatal register path, and does not introduce unrelated changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
register-by-walletwas fire-and-forget whilegetFarcasterProfileran in parallel. On first connect, the DB was empty so profile fetch fell through to external APIs — doubling SteemHunt/Neynar calls.getFarcasterProfilereads from cache.Fixes #632
Tracks realproject7/agent-os#311
Test plan
🤖 Generated with Claude Code