[#663] Fix CLI build failure (corrupted lockfile)

[realproject7]

Summary

• Regenerated package-lock.json which was missing resolution entries for tsup's transitive dependencies (bundle-require, joycon, tree-kill, etc.)
• Root cause: corrupted lockfile — tsup@8.5.1 was installed in packages/cli/node_modules/ but its 17 transitive dependencies had no entries in the lockfile, so npm never installed them
• Fix: full clean install (rm -rf node_modules package-lock.json && npm install) to regenerate a correct lockfile

Verification

cd packages/cli && npm run build   # ✅ succeeds — ESM dist/index.js (1.08 MB)
node dist/index.js --help          # ✅ shows CLI help

Note: acceptance criteria mentions dist/index.cjs but the build is configured for ESM format (tsup.config.ts: format: ["esm"]), so the output is dist/index.js.

Test plan

• cd packages/cli && npm run build succeeds
• node dist/index.js --help displays all 5 commands
• No other files changed besides package-lock.json

Fixes #663

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
plotlink	Ignored		Mar 31, 2026 7:59am

[project7-interns]

T2b APPROVE

Lockfile-only change — correct fix for corrupted transitive dependency resolution. Reviewed:

1. Single file changed — only package-lock.json, no source changes. Clean.
2. Root cause is sound — tsup's transitive deps missing from lockfile explains the build failure.
3. Version bump 0.1.11→0.1.12 in lockfile reflects current package.json state; no concern.
4. Dependency version bumps are expected from a clean npm install picking up latest semver-compatible versions.

Minor note: T3 correctly flagged the ESM vs CJS discrepancy — acceptance criteria says dist/index.cjs but tsup config targets ESM. Worth updating the issue/docs if this matters for distribution.

[project7-interns]

Verdict: REQUEST CHANGES

Summary

This does make the missing tsup runtime entries appear in the lockfile, but it does so by regenerating the entire monorepo lockfile and pulling in unrelated dependency updates outside the CLI build scope.

Findings

• [medium] The fix is broader than the ticket and introduces unrelated dependency drift across the repo.
  • File: package-lock.json:330
  • Suggestion: make the build fix targeted to packages/cli by declaring the missing tsup runtime deps or pinning/adjusting the tsup dependency, then regenerate the lockfile without refreshing unrelated trees. Right now this PR also upgrades non-CLI packages such as wagmi/@wagmi/connectors (package-lock.json:13483, package-lock.json:13508) and a large set of @aws-sdk/* entries, which creates avoidable regression risk for a CLI build-only ticket.

Decision

Requesting changes because the implementation is not minimal or focused enough for #663. The build fix itself may be valid, but it should land without a repo-wide lockfile refresh.

[project7-interns]

T2b APPROVE (re-review after force-push)

Much cleaner — scoped to CLI workspace only. +323/-66 vs the original +1113/-939.

What changed:

• packages/cli/package.json: 9 missing tsup transitive deps added as explicit devDependencies ✅
• package-lock.json: corresponding lockfile entries, no unrelated dependency drift ✅

One note (non-blocking): The lockfile diff removes a stale @plotlink/sdk workspace symlink and its dependency entry from the CLI package. This appears correct — CLI's package.json doesn't list @plotlink/sdk as a dependency, so the old lockfile had a stale reference. The SDK workspace is also now marked extraneous: true. Worth confirming the CLI doesn't import from @plotlink/sdk at runtime, but this looks like lockfile cleanup, not a regression.

[project7-interns]

Verdict: APPROVE

Summary

The revised PR narrows the fix to the CLI workspace and adds the missing tsup runtime dependencies explicitly in packages/cli/package.json, with corresponding scoped lockfile updates.

Findings

• None blocking.

Decision

Approving because the prior scope-creep concern is resolved and the change now matches #663's intended build/dependency fix.