[#674] Fix user scoring logic bugs#680
Merged
realproject7 merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
- spam_label=2 (verified non-spammer) no longer zeroed out; only spam_label=1 causes instant disqualification - spam_label=0/blank applies a small -3 penalty instead of instant zero; spam_label=2 gets a +2 bonus - quotient_score used as-is (0-1 scale), no longer divided by 100 Result: project7 (FID 8106) scores 64 with tag Writer. Distribution: 89 users at 60-79, 1208 at 40-59, sensible spread. Fixes #674 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Mar 31, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Script fix (+8/-5) is correct:
- spam_label=2 no longer zeroed — old code treated any non-zero/non-blank as spam. Now only
spamLabel === 1disqualifies. ✅ - Graduated spam penalty — unknown (0/blank) gets -3 penalty, verified (2) gets +2 bonus, spam (1) already exited. Clean ternary. ✅
- quotient_score fix — was divided by 100 when data is already 0-1 range. Removing
/100is correct. ✅
Archive CSV is the scored output — reasonable to include for reproducibility.
project7-interns
approved these changes
Mar 31, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR fixes the two scoring bugs described in issue #674 with a minimal, focused change to scripts/score-users.mjs, then re-runs the generated archive output. The updated logic now treats spam_label as intended and uses quotient_score on its native 0-1 scale.
Findings
- No blocking findings.
Decision
Approve. The code matches the requested bug fixes, keeps the change set focused, and preserves the existing scoring structure outside the corrected logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spam_labelhandling:spam_label=2(verified) no longer zeroed out; onlyspam_label=1disqualifies;0/blankgets -3 penalty instead of instant zeroquotient_score: used as-is on 0-1 scale, no longer divided by 100Changed files
scripts/score-users.mjs— 3 logic fixesarchive/dropcast-users-scored-20260330.csv— updated outputVerification
Test plan
npm run buildpassesFixes #674
🤖 Generated with Claude Code