Redesign Stories tab — compact stats + collapsible cards#706
Redesign Stories tab — compact stats + collapsible cards#706realproject7 merged 2 commits intomainfrom
Conversation
…le details - Writer Stats: replace grid with compact horizontal stat row - Storyline cards: inline key stats (plots, holders, views, price, date) on one line with better visual hierarchy - TVL, donations, donation history collapsed into expandable details - Donation history collapsed by default (own profile only) - All formatUnits outputs go through formatPrice (4 decimals max) - Remove unused StatCell component Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Thorough redesign that preserves all data while improving scan-ability. Verified against #699:
- ✅ All information preserved — nothing removed, just reorganized into primary/secondary hierarchy
- ✅ Writer Stats: grid → compact flex-wrap row with middot separators
- ✅ Storyline cards: key stats (plots, holders, views, price, date) inline; TVL/donations/history in collapsible
<details> - ✅ Claim royalties stays visible (not hidden in collapsible) — correct, it's a primary action
- ✅ Own profile: claim, genre edit, donation history all present
- ✅ Public profile: read-only (isOwnProfile guards intact)
- ✅ Number formatting via
formatPrice(4 decimal cap) - ✅ Mobile responsive:
flex-wrapwithgap-x-3 gap-y-1for natural wrapping - ✅ Removed unused
StatCellcomponent — clean cleanup - ✅ Build passes
+102/−84, single file. No concerns.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The layout direction is better, but the current rewrite drops required information in two cases instead of only reorganizing it.
Findings
- [medium] The compact Writer Stats row removes the donations and claimable metrics entirely when their values are zero. Issue #699 explicitly requires that summary to keep showing storylines, total plots, total holders, total donations, and total claimable, and the previous implementation still rendered those fields as
—when zero. With the new guards, zero-value writers lose those stats completely.- File:
src/app/profile/[address]/page.tsx:709 - Suggestion: Keep the donations and claimable labels visible in the summary row for all eligible profiles, and render
—or0when the amount is zero instead of omitting the metric.
- File:
- [medium] Public profiles no longer show per-story donation totals/counts at all. The redesign requirement lists donation total + count as secondary storyline information, with only donation history restricted to own-profile views. Right now
StoryDonationCountis still gated behindisOwnProfile, so non-owners lose that storyline data entirely.- File:
src/app/profile/[address]/page.tsx:929 - Suggestion: Render
StoryDonationCountfor any viewer inside the expandable details, and keep onlyProfileDonationHistorybehind the own-profile gate.
- File:
Decision
Requesting changes because the current implementation removes required information instead of just reorganizing it.
…on count - Writer Stats: show donations and claimable with "—" when zero instead of hiding them entirely - StoryDonationCount visible on public profiles too (only donation history rows remain own-profile-only) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up revision addresses the missing-information regressions from my prior review and keeps the redesigned Stories tab aligned with issue #699.
Findings
- None.
Decision
The Writer Stats row now preserves donations and claimable metrics even at zero values, and per-story donation totals remain visible on public profiles while donation history stays own-profile-only. I am approving.
Summary
<details>— collapsed by defaultStatCellcomponentformatPrice(4 decimals max)Fixes #699
Self-Verification
npm run buildpasses🤖 Generated with Claude Code