Skip to content

Redesign Stories tab — compact stats + collapsible cards#706

Merged
realproject7 merged 2 commits intomainfrom
task/699-stories-tab-redesign
Apr 1, 2026
Merged

Redesign Stories tab — compact stats + collapsible cards#706
realproject7 merged 2 commits intomainfrom
task/699-stories-tab-redesign

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Writer Stats: replaced grid layout with compact horizontal stat row (stories, plots, holders, donations, claimable all inline)
  • Storyline cards: key stats (plots, holders, views, price, date) on one compact line with middot separators
  • Secondary info (TVL, donations, donation history) moved into collapsible <details> — collapsed by default
  • Donation count + donation history now render inside expandable section (own profile only)
  • Removed unused StatCell component
  • All number formatting goes through formatPrice (4 decimals max)

Fixes #699

Self-Verification

  • All current information still displayed (nothing removed)
  • Own profile: Claim, genre edit, donation history all functional
  • Public profile: read-only, no action buttons
  • Royalties truncated to 4 decimals max
  • Mobile (375px): clean, no overflow — inline stats wrap naturally
  • Desktop: compact horizontal layout
  • Matches PlotLink terminal aesthetic
  • npm run build passes

🤖 Generated with Claude Code

…le details

- Writer Stats: replace grid with compact horizontal stat row
- Storyline cards: inline key stats (plots, holders, views, price, date)
  on one line with better visual hierarchy
- TVL, donations, donation history collapsed into expandable details
- Donation history collapsed by default (own profile only)
- All formatUnits outputs go through formatPrice (4 decimals max)
- Remove unused StatCell component

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Apr 1, 2026 11:10am

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE

Thorough redesign that preserves all data while improving scan-ability. Verified against #699:

  • ✅ All information preserved — nothing removed, just reorganized into primary/secondary hierarchy
  • ✅ Writer Stats: grid → compact flex-wrap row with middot separators
  • ✅ Storyline cards: key stats (plots, holders, views, price, date) inline; TVL/donations/history in collapsible <details>
  • ✅ Claim royalties stays visible (not hidden in collapsible) — correct, it's a primary action
  • ✅ Own profile: claim, genre edit, donation history all present
  • ✅ Public profile: read-only (isOwnProfile guards intact)
  • ✅ Number formatting via formatPrice (4 decimal cap)
  • ✅ Mobile responsive: flex-wrap with gap-x-3 gap-y-1 for natural wrapping
  • ✅ Removed unused StatCell component — clean cleanup
  • ✅ Build passes

+102/−84, single file. No concerns.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The layout direction is better, but the current rewrite drops required information in two cases instead of only reorganizing it.

Findings

  • [medium] The compact Writer Stats row removes the donations and claimable metrics entirely when their values are zero. Issue #699 explicitly requires that summary to keep showing storylines, total plots, total holders, total donations, and total claimable, and the previous implementation still rendered those fields as when zero. With the new guards, zero-value writers lose those stats completely.
    • File: src/app/profile/[address]/page.tsx:709
    • Suggestion: Keep the donations and claimable labels visible in the summary row for all eligible profiles, and render or 0 when the amount is zero instead of omitting the metric.
  • [medium] Public profiles no longer show per-story donation totals/counts at all. The redesign requirement lists donation total + count as secondary storyline information, with only donation history restricted to own-profile views. Right now StoryDonationCount is still gated behind isOwnProfile, so non-owners lose that storyline data entirely.
    • File: src/app/profile/[address]/page.tsx:929
    • Suggestion: Render StoryDonationCount for any viewer inside the expandable details, and keep only ProfileDonationHistory behind the own-profile gate.

Decision

Requesting changes because the current implementation removes required information instead of just reorganizing it.

…on count

- Writer Stats: show donations and claimable with "—" when zero
  instead of hiding them entirely
- StoryDonationCount visible on public profiles too (only donation
  history rows remain own-profile-only)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The follow-up revision addresses the missing-information regressions from my prior review and keeps the redesigned Stories tab aligned with issue #699.

Findings

  • None.

Decision

The Writer Stats row now preserves donations and claimable metrics even at zero values, and per-story donation totals remain visible on public profiles while donation history stays own-profile-only. I am approving.

@realproject7 realproject7 merged commit 6ca5e8d into main Apr 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesign Stories tab layout — tidy up writer stats + storyline cards

2 participants