Redesign Portfolio tab — compact layout with collapsible sections#707
Redesign Portfolio tab — compact layout with collapsible sections#707realproject7 merged 2 commits intomainfrom
Conversation
…llapsible sections - Portfolio summary: compact horizontal row with value, token count, best 24h pick - Token holdings: inline stats per card (balance, price, entry, date) with middot separators - Donations: unified card for received + given, donations given collapsible - Removed confusing "total loaded" text from donations given header - Trading history: collapsible with compact inline rows (buy/sell, title, amount, date) - Consistent border-border card styling throughout Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Solid Portfolio tab redesign. All #700 criteria verified:
- ✅ All info preserved — portfolio value, holdings, donations, trading history all present
- ✅ Portfolio summary: grid → compact horizontal flex-wrap row (value, token count, best 24h)
- ✅ Token holdings: inline stats with middot separators, consistent card styling
- ✅ Donations: unified card grouping received + given; given section is collapsible
<details> - ✅ "total loaded" text removed
- ✅ Trading history: collapsible
<details>(open by default), compact single-row trades - ✅ Own profile vs public profile: isOwnProfile guards intact
- ✅ Mobile responsive:
flex-wrapwith gap for natural wrapping - ✅ Consistent card styling throughout all sections
- ✅ Build passes
Minor note: trading history date drops year (now "short month + day" only). Acceptable trade-off for compact rows.
+219/−235, single file. No blocking concerns.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The portfolio layout is cleaner, but the holdings rewrite drops required unit information from the per-token price fields.
Findings
- [medium] The inline holdings stats no longer show the reserve unit on current price and entry price. Issue #700 requires both fields to be displayed as
PLOT + USD, and the previous implementation included${RESERVE_LABEL}for each. In the new row they render only the numeric value plus optional USD, which makes those prices ambiguous and removes required information.- File:
src/app/profile/[address]/page.tsx:1468 - Suggestion: Restore
${RESERVE_LABEL}on both thepriceandentryvalues in the holdings row so each token card still shows current price and entry price asPLOT + USD.
- File:
Decision
Requesting changes because the redesign currently omits required unit information from the token holdings section.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up revision addresses the missing unit label regression and keeps the portfolio redesign aligned with issue #700.
Findings
- None.
Decision
The holdings rows now show current price and entry price in the required PLOT + USD format again, and the rest of the compact portfolio layout remains consistent with the redesign goals. I am approving.
Summary
<details>with compact inline rowsFixes #700
Self-Verification
npm run buildpasses🤖 Generated with Claude Code