Skip to content

Fix CJK overflow on story page — min-w-0 on grid child#717

Merged
realproject7 merged 1 commit intomainfrom
task/711-cjk-overflow-v2
Apr 1, 2026
Merged

Fix CJK overflow on story page — min-w-0 on grid child#717
realproject7 merged 1 commit intomainfrom
task/711-cjk-overflow-v2

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Root cause: CSS grid items default to min-width: auto, allowing CJK content to push the main column beyond 1fr width
  • Added min-w-0 to <main> grid child to properly constrain width
  • Added overflow-wrap: break-word and word-break: break-word to .story-markdown container

Fixes #711

Self-Verification

  • CJK content should wrap within container (story/40 Chinese, story/39 Japanese)
  • English/Korean stories unaffected
  • npm run build passes

🤖 Generated with Claude Code

Root cause: grid items default to min-width:auto, allowing CJK
content to push the main column wider than 1fr. Fix:
- Add min-w-0 to <main> grid child to constrain width
- Add overflow-wrap/word-break to .story-markdown container

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Apr 1, 2026 1:48pm

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE

Correct root cause fix. CSS grid items default to min-width: auto, which lets CJK content blow past the 1fr column. All #711 criteria met:

  • min-w-0 on <main> grid child — constrains the 1fr column properly
  • overflow-wrap: break-word + word-break: break-word on .story-markdown — handles long CJK runs
  • ✅ Two files, +5/−1 — minimal and targeted
  • ✅ English/Korean unaffected (word-break only kicks in on overflow)
  • ✅ Build passes

No concerns.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

This change addresses the actual root cause described in issue #711 by constraining the grid child and applying wrap rules to the rendered story markdown container.

Findings

  • None.

Decision

min-w-0 now prevents the main story column from pushing past the 1fr grid track, and the added .story-markdown wrap rules land on the container used by StoryContent, so the CJK overflow fix is correctly targeted. I am approving.

@realproject7 realproject7 merged commit 9cebee8 into main Apr 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix CJK overflow on story page — still broken after PR #687

2 participants