Skip to content

Portfolio tab v4 — structured label-value grid layout#727

Merged
realproject7 merged 2 commits intomainfrom
task/725-portfolio-v4
Apr 1, 2026
Merged

Portfolio tab v4 — structured label-value grid layout#727
realproject7 merged 2 commits intomainfrom
task/725-portfolio-v4

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Portfolio summary: grid-cols-[auto_1fr] for Value, Tokens, Best 24h
  • Holdings: bordered cards with grid-cols-[auto_1fr] for all stats (Value, Change, Balance, Price, Entry, Traded)
  • Genre as inline text next to title (not a badge that breaks layout)
  • Donations: structured grid for Received/Given, grid-cols-[auto_1fr_auto] for per-story rows
  • Trades: two-line format per trade (action + title, then tokens + amount + date in grid)
  • No inline flex-wrap — all data in predictable grid positions

Fixes #725

Self-Verification

  • Mobile (375px): every label-value pair on a predictable row
  • Genre tag doesn't break layout
  • Portfolio summary clean: value, tokens, best pick each on own row
  • Holdings: all stats in label-value grid
  • Donations: received/given clearly separated
  • Trade rows: consistent format, no wrapping
  • No inline flex-wrap for stats
  • npm run build passes

🤖 Generated with Claude Code

Portfolio summary: grid-cols-[auto_1fr] for Value/Tokens/Best 24h
Holdings: bordered cards with grid-cols-[auto_1fr] for all stats
  (Value, Change, Balance, Price, Entry, Traded)
Donations: structured grid for Received/Given totals, grid rows
  for per-story breakdown
Trades: two-line per trade (Buy/Sell + title, then tokens + amount
  + date in grid)
No inline flex-wrap — all data in predictable grid positions

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE

Follows the #725 wireframe precisely. All criteria met:

Portfolio Summary:

  • grid-cols-[auto_1fr] for Value/Tokens/Best 24h

Holdings:

  • ✅ Bordered cards with grid-cols-[auto_1fr] for all stats (Value, Change, Balance, Price, Entry, Traded)
  • ✅ Genre as inline muted text (not badge) — won't break layout

Donations:

  • ✅ Structured grid-cols-[auto_1fr] for Received/Given with sub-count rows
  • ✅ Per-story rows: grid-cols-[auto_1fr_auto] — story / amount / date+link

Trades:

  • ✅ Two-line format: action + title, then grid-cols-[auto_1fr_auto] for tokens/amount/date

  • divide-y between trades

  • ✅ Zero flex-wrap for stats — all predictable grid positions

  • ✅ Numbers right-aligned, USD in muted

  • ✅ Build passes

+155/−180, single file. No concerns.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Apr 1, 2026 3:07pm

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The portfolio summary, holdings, and donation sections are much closer to the wireframe, but the trading-history rows still miss one part of issue #725's exact mobile layout.

Findings

  • [medium] The trade rows still place the date and tx link in the same grid-cols-[auto_1fr_auto] metadata row as the token count and amount, instead of rendering the date/link on their own line below. That leaves each trade at a two-line layout rather than the three-line wireframe requested in issue #725 and makes the right edge more prone to crowding on 375px.
    • File: src/app/profile/[address]/page.tsx:1600
    • Suggestion: keep the current first line for action + title, keep the second line for token count and amount/USD, then move the date + tx link into a separate third row aligned like the wireframe.

Decision

Issue #725 explicitly asks for the exact mobile wireframe and calls for the trade row's date/link to sit below the amount row, so I'm requesting one more layout adjustment before approval.

Row 1: Buy/Sell + title
Row 2: token count + amount (grid-cols-[auto_1fr])
Row 3: date + tx link

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The follow-up revision fixes the remaining trade-row layout issue and brings the portfolio tab in line with issue #725's structured mobile wireframe.

Findings

  • None.

Decision

The trading-history rows now render as action/title, then tokens + amount, then a separate date/link row, which resolves my prior finding. I am approving.

@realproject7 realproject7 merged commit 4c6328f into main Apr 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Portfolio tab v4 — structured rows, exact wireframe

2 participants