[#739] Fix plot_count +1 bug: reconcile after genesis plot

src/app/api/cron/backfill/route.ts

@@ -307,6 +307,9 @@ async function processStorylineCreated(
     throw new Error(`Database error (genesis plot): ${plotError.message}`);
   }
 
+  // Reconcile plot_count from actual plots rows (prevents genesis double-count)
+  await reconcileStorylinePlotCount(supabase, Number(storylineId));
+
   return { genesisPlotFailed: false };
 }
 

src/app/api/cron/reconcile-plots/route.ts

@@ -0,0 +1,58 @@
+import { NextResponse } from "next/server";
+import { createServerClient } from "../../../../../lib/supabase";
+import { reconcileStorylinePlotCount } from "../../../../../lib/reconcile";
+import { STORY_FACTORY } from "../../../../../lib/contracts/constants";
+
+/**
+ * One-time reconciliation endpoint: re-counts plot_count for ALL storylines
+ * from the plots table. Safe to run multiple times (idempotent).
+ *
+ * POST /api/cron/reconcile-plots
+ */
+/** Cron authorization — fail closed in production when CRON_SECRET is unset */
+function verifyCron(req: Request): boolean {
+  const secret = process.env.CRON_SECRET;
+  if (!secret) {
+    return process.env.NODE_ENV !== "production";
+  }
+  const authHeader = req.headers.get("authorization");
+  return authHeader === `Bearer ${secret}`;
+}
+
+export async function POST(req: Request) {
+  if (!verifyCron(req)) {
+    return NextResponse.json({ error: "Unauthorized" }, { status: 401 });
+  }
+  const supabase = createServerClient();
+  if (!supabase) {
+    return NextResponse.json({ error: "Supabase not configured" }, { status: 500 });
+  }
+
+  // Fetch all storyline IDs
+  const { data: storylines, error: fetchError } = await supabase
+    .from("storylines")
+    .select("storyline_id")
+    .eq("contract_address", STORY_FACTORY.toLowerCase());
+
+  if (fetchError) {
+    return NextResponse.json({ error: fetchError.message }, { status: 500 });
+  }
+
+  if (!storylines || storylines.length === 0) {
+    return NextResponse.json({ reconciled: 0 });
+  }
+
+  let reconciled = 0;
+  const errors: string[] = [];
+
+  for (const s of storylines) {
+    try {
+      await reconcileStorylinePlotCount(supabase, s.storyline_id);
+      reconciled++;
+    } catch (err) {
+      errors.push(`storyline ${s.storyline_id}: ${err instanceof Error ? err.message : String(err)}`);
+    }
+  }
+
+  return NextResponse.json({ reconciled, total: storylines.length, errors });
+}

src/app/api/index/storyline/route.ts

@@ -1,6 +1,6 @@
 import { NextResponse } from "next/server";
 import { type Hex, decodeEventLog, encodeEventTopics } from "viem";
 import { publicClient, getReceiptWithRetry } from "../../../../../lib/rpc";
 import { createServerClient } from "../../../../../lib/supabase";
 import { validateRecentTx } from "../../../../../lib/index-auth";
 import {
@@ -12,6 +12,7 @@
 import { hashContent } from "../../../../../lib/content";
 import { GENRES, LANGUAGES } from "../../../../../lib/genres";
 import type { Database } from "../../../../../lib/supabase";
+import { reconcileStorylinePlotCount } from "../../../../../lib/reconcile";
 
 const IPFS_GATEWAY = "https://ipfs.filebase.io/ipfs/";
 const IPFS_TIMEOUT_MS = 10_000;
@@ -179,5 +180,8 @@
     return error(`Database error (genesis plot): ${plotDbError.message}`, 500);
   }
 
+  // Reconcile plot_count from actual plots rows (prevents genesis double-count)
+  await reconcileStorylinePlotCount(supabase, Number(storylineId));
+
   return NextResponse.json({ success: true });
 }