Skip to content

[#742] Writer + Reader tab v10: active tag, portfolio boxes, donation boxes#743

Merged
realproject7 merged 2 commits intomainfrom
task/742-tab-v10-polish
Apr 2, 2026
Merged

[#742] Writer + Reader tab v10: active tag, portfolio boxes, donation boxes#743
realproject7 merged 2 commits intomainfrom
task/742-tab-v10-polish

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Move active/complete tag to right of deadline counter: "Deadline: 1d 7h 41m · active"
  • Reader Portfolio summary: converted to 4-box grid matching Writer Stats (PLOT value, USD value, Holdings count, Best 24h %)
  • Reader Donations: converted to bordered box layout (Received box, Given box) with per-story donation rows kept below

Fixes #742

Test plan

  • Writer tab: deadline row reads "Deadline: Xd Xh Xm · active" (tag after counter)
  • Writer tab: complete stories show "· complete"
  • Reader Portfolio: 4-box grid (2-col mobile, 4-col desktop) with PLOT/USD/Holdings/Best 24h
  • Reader Donations: Received and Given as bordered boxes in 2-col grid
  • Per-story donation rows still appear below donation boxes
  • Verify at 375px mobile viewport

🤖 Generated with Claude Code

… donation boxes

1. Move active/complete tag after deadline counter (Deadline: 1d 7h · active)
2. Reader Portfolio summary: 4-box grid (PLOT value, USD, Holdings, Best 24h)
3. Reader Donations: bordered box layout (Received, Given) with per-story rows below

Fixes #742

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Apr 2, 2026 9:22am

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b REQUEST CHANGES — 1 issue found.

Items 2 and 3 (Portfolio 4-box grid, Donation boxes) look correct.

Issue: Unconditional dot separator in deadline row (~line 922)
The dot separator is now rendered unconditionally, but for complete stories (sunset=true) there is no DeadlineCountdown preceding it. This renders as "· complete" with a leading dot and nothing before it.

Fix: wrap the dot inside the DeadlineCountdown conditional:

{!storyline.sunset && storyline.last_plot_time && (
  <>
    <DeadlineCountdown lastPlotTime={storyline.last_plot_time} />
    <span className="text-muted">·</span>
  </>
)}

Everything else is clean — single file, net -5 lines, box layouts match Writer Stats pattern.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The Reader dashboard box changes look aligned with issue #742, but the Writer deadline-row tweak introduces a regression for completed stories.

Findings

  • [medium] The deadline separator is now unconditional, so completed stories render a leading · complete even when there is no countdown. Issue #738 previously required sunset/complete stories to show just complete plus the created date, and this change regresses that state.
    • File: src/app/profile/[address]/page.tsx:925
    • Suggestion: only render the separator when a deadline countdown is present, so active rows read Deadline: … · active but complete rows stay complete.

Decision

Requesting changes because the active-tag placement is fixed, but the completed-storyline layout now regresses.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE — re-reviewed after fix. Dot separator now correctly inside the DeadlineCountdown conditional. Complete stories render just "complete" without leading dot. All 3 items verified:

  1. Active tag after deadline: "Deadline: Xd Xh Xm · active" ✓
  2. Reader Portfolio 4-box grid (PLOT/USD/Holdings/Best 24h) ✓
  3. Reader Donations bordered box layout (Received/Given) ✓

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The follow-up fix resolves the completed-story regression. The deadline row now reads Deadline: … · active for active stories while completed stories remain just complete, and the Reader portfolio/donation dashboard box changes still match issue #742.

Findings

  • None.

Decision

Approving because the review blocker is addressed and I do not see a remaining code-level mismatch against the ticket.

@realproject7 realproject7 merged commit c4445f3 into main Apr 2, 2026
5 checks passed
@realproject7 realproject7 deleted the task/742-tab-v10-polish branch April 2, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Writer + Reader tab v10 — active tag position, Reader dashboard boxes

2 participants