Skip to content

[#749] Remove Donations/Trades from Reader, add Activity Stats dashboard #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realproject7 merged 1 commit into from
Apr 2, 2026
Merged

[#749] Remove Donations/Trades from Reader, add Activity Stats dashboard #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 31 additions & 60 deletions src/app/profile/[address]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import { getFullUserProfile } from "../../../../lib/actions";
import { truncateAddress } from "../../../../lib/utils";
import { formatPrice, formatSupply } from "../../../../lib/format";
import { getTokenPrice, mcv2BondAbi, erc20Abi, type TokenPriceInfo, get24hPriceChange, getTokenTVL } from "../../../../lib/price";

Check warning on line 14 in src/app/profile/[address]/page.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck 

'TokenPriceInfo' is defined but never used
import { browserClient } from "../../../../lib/rpc";
import type { FarcasterProfile } from "../../../../lib/farcaster";
import type { AgentMetadata } from "../../../../lib/contracts/erc8004";
Expand Down Expand Up @@ -133,7 +133,7 @@
if (r <= 0) clearInterval(interval);
}, 1000);
return () => clearInterval(interval);
}, [dbUser?.steemhunt_fetched_at]);

Check warning on line 136 in src/app/profile/[address]/page.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck 

React Hook useEffect has a missing dependency: 'COOLDOWN_MS'. Either include it or remove the dependency array

const onCooldown = cooldownRemaining > 0;

Expand Down Expand Up @@ -658,7 +658,7 @@
});

// Claimable royalties (own profile only)
const { data: royaltyInfo } = useQuery({

Check warning on line 661 in src/app/profile/[address]/page.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck 

'royaltyInfo' is assigned a value but never used
queryKey: ["profile-royalties", address],
queryFn: async () => {
const [balance, claimed] = await browserClient.readContract({
Expand Down Expand Up @@ -798,7 +798,7 @@
}) {
const tokenAddr = storyline.token_address as Address;

const { data: priceInfo } = useQuery({

Check warning on line 801 in src/app/profile/[address]/page.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck 

'priceInfo' is assigned a value but never used
queryKey: ["profile-story-price", storyline.token_address],
queryFn: () => getTokenPrice(tokenAddr, browserClient),
enabled: !!storyline.token_address,
Expand Down Expand Up @@ -1069,7 +1069,7 @@

const DONATION_PAGE_SIZE = 10;

function ProfileDonationHistory({ storylineId }: { storylineId: number }) {

Check warning on line 1072 in src/app/profile/[address]/page.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck 

'ProfileDonationHistory' is defined but never used
const { data: plotUsd } = usePlotUsdPrice();
const {
data,
Expand Down Expand Up @@ -1337,7 +1337,7 @@
const {
data: donationPages,
isLoading: donGivenLoading,
isFetchingNextPage: donFetchingNext,

Check warning on line 1340 in src/app/profile/[address]/page.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck 

'donFetchingNext' is assigned a value but never used
fetchNextPage: donFetchNext,
hasNextPage: donHasNext,
} = useInfiniteQuery({
Expand Down Expand Up @@ -1515,65 +1515,7 @@
</>
)}

{/* Donations — structured card */}
{(hasDonationsReceived || (isOwnProfile && hasDonationsGiven)) && (
<div className="border-border rounded border px-4 py-3 text-xs">
<p className="text-muted mb-2 text-[10px] uppercase tracking-wider">Donations</p>
<div className="grid grid-cols-2 gap-2">
{hasDonationsReceived && (
<div className="border-border rounded border px-2 py-1.5 text-center">
<div className="text-foreground text-sm font-bold">{formatPrice(formatUnits(donationsReceived!.total, 18))}</div>
<div className="text-muted text-[9px]">Received · {donationsReceived!.count}</div>
</div>
)}
{isOwnProfile && hasDonationsGiven && (
<div className="border-border rounded border px-2 py-1.5 text-center">
<div className="text-foreground text-sm font-bold">{formatPrice(formatUnits(totalDonated, 18))}</div>
<div className="text-muted text-[9px]">Given · {donationTotalCount}</div>
</div>
)}
</div>
{isOwnProfile && hasDonationsGiven && (
<div className="mt-3 space-y-2">
{donationsGiven.map((d) => (
<div key={d.id} className="grid grid-cols-[auto_1fr_auto] gap-x-2 items-baseline text-xs">
<Link
href={`/story/${d.storyline_id}`}
className="text-foreground hover:text-accent transition-colors"
>
Story #{d.storyline_id}
</Link>
<span className="text-foreground text-right font-medium">
{formatPrice(formatUnits(BigInt(d.amount), 18))} {RESERVE_LABEL}
</span>
<span className="text-muted flex items-center gap-1">
{d.block_timestamp && (
<time dateTime={d.block_timestamp}>
{new Date(d.block_timestamp).toLocaleDateString("en-US", { month: "short", day: "numeric" })}
</time>
)}
{d.tx_hash && (
<a href={`${EXPLORER_URL}/tx/${d.tx_hash}`} target="_blank" rel="noopener noreferrer" className="hover:text-accent">&#x2197;</a>
)}
</span>
</div>
))}
{donHasNext && (
<button
onClick={() => donFetchNext()}
disabled={donFetchingNext}
className="text-accent hover:text-foreground mt-1 w-full text-center text-xs transition-colors disabled:opacity-50"
>
{donFetchingNext ? "Loading..." : `Load more (${donationTotalCount - donationsGiven.length} remaining)`}
</button>
)}
</div>
)}
</div>
)}

{/* Trading History */}
<PortfolioTradingHistory address={address} plotUsd={plotUsd} />
{/* Donations and Trading History moved to Activity tab */}
</div>
);
}
Expand Down Expand Up @@ -1862,11 +1804,40 @@
);
}

// Activity Stats
const tradeEntries = feed.filter((e) => e.type === "bought" || e.type === "sold");
const donationEntries = feed.filter((e) => e.type === "donated");
const totalTradeAmount = tradeEntries.reduce((sum, e) => sum + (e.reserveAmount ?? 0), 0);
const totalDonationAmount = donationEntries.reduce((sum, e) => sum + (e.reserveAmount ?? 0), 0);

const visible = feed.slice(0, visibleCount);
const hasMore = visibleCount < feed.length;

return (
<div className="mt-6">
<div className="mt-6 space-y-4">
{/* Activity Stats dashboard */}
<p className="text-muted text-[10px] uppercase tracking-wider">Activity Stats</p>
<div className="border-border rounded border px-4 py-3 text-xs">
<div className="grid grid-cols-2 sm:grid-cols-4 gap-2">
<div className="border-border rounded border px-2 py-1.5 text-center">
<div className="text-foreground text-sm font-bold">{tradeEntries.length}</div>
<div className="text-muted text-[9px]">Trades</div>
</div>
<div className="border-border rounded border px-2 py-1.5 text-center">
<div className="text-foreground text-sm font-bold">{totalTradeAmount > 0 ? formatPrice(totalTradeAmount) : "—"}</div>
<div className="text-muted text-[9px]">Trade Vol ({RESERVE_LABEL})</div>
</div>
<div className="border-border rounded border px-2 py-1.5 text-center">
<div className="text-foreground text-sm font-bold">{donationEntries.length}</div>
<div className="text-muted text-[9px]">Donations</div>
</div>
<div className="border-border rounded border px-2 py-1.5 text-center">
<div className="text-foreground text-sm font-bold">{totalDonationAmount > 0 ? formatPrice(totalDonationAmount) : "—"}</div>
<div className="text-muted text-[9px]">Donated ({RESERVE_LABEL})</div>
</div>
</div>
</div>

<div className="space-y-1.5">
{visible.map((entry, i) => (
<FeedRow key={`${entry.type}-${entry.timestamp}-${i}`} entry={entry} plotUsd={plotUsd} />
Expand Down
Loading