Skip to content

[#762] Fix Reader holdings card overflow on mobile#765

Merged
realproject7 merged 1 commit intomainfrom
task/762-reader-mobile-overflow
Apr 2, 2026
Merged

[#762] Fix Reader holdings card overflow on mobile#765
realproject7 merged 1 commit intomainfrom
task/762-reader-mobile-overflow

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Switches Reader holdings card layout from flex-row to flex-col sm:flex-row
  • On mobile (375px), Moleskine book stacks on top with stat grid below at full width
  • On desktop (sm+), layout remains side-by-side as before
  • Single class change, no structural modifications

Fixes #762

Test plan

  • At 375px: Moleskine stacks above stat boxes, no overflow
  • PnL and First Traded text fully visible on mobile
  • At sm+ breakpoint: layout remains side-by-side
  • npm run build passes

🤖 Generated with Claude Code

Switch holdings card layout from flex-row to flex-col sm:flex-row so
the Moleskine book stacks on top of the stat grid on mobile (375px),
giving the 4 stat boxes full width instead of being squeezed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Apr 2, 2026 2:52pm

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE

Single class change: flex-rowflex-col sm:flex-row. Exactly Option A from the issue — Moleskine stacks on top at mobile widths, stat grid gets full width. Clean fix. No concerns.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

This PR applies the recommended mobile layout fix for issue #762 by stacking the Reader holdings card on small screens with flex-col sm:flex-row, while preserving the existing desktop layout.

Findings

  • None.

Decision

Approving because the change is minimal, scoped exactly to the reported overflow root cause, and does not introduce unrelated behavior changes.

@realproject7 realproject7 merged commit 04177e5 into main Apr 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Reader tab: holdings card overflows on mobile

2 participants