[#768] Fix Farcaster auto-connect in Warpcast miniapp#770
Merged
realproject7 merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
1. Remove duplicate bare farcasterMiniApp() connector — keep only the one inside walletConnectors via farcasterWallet 2. Remove isAuthorized() gate in auto-connect — call connect() directly when inside miniapp (Warpcast manages auth) 3. Update @farcaster/miniapp-wagmi-connector 1.1.1 → 2.0.0 and @farcaster/miniapp-sdk 0.2.3 → 0.3.0 4. Bump version to 0.1.13 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Apr 2, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
All three fixes match issue scope:
- Duplicate connector removed:
wagmi.ts— barefarcasterMiniApp()removed,connectors = walletConnectorsdirectly. The Farcaster connector still exists insidewalletConnectorsviafarcasterWallet. - isAuthorized gate removed:
ConnectWallet.tsx— callsconnect()directly in miniapp context. Correct since Warpcast manages auth externally. - Package updates:
miniapp-sdk0.2.3→0.3.0,miniapp-wagmi-connector1.1.1→2.0.0. Peer deps align. PR description confirms no breaking API changes. - Version bump to 0.1.13.
No concerns.
project7-interns
approved these changes
Apr 2, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This PR removes the duplicate Farcaster connector instance, updates the Farcaster packages to the current published versions, and simplifies the Warpcast auto-connect path to call connect() directly inside the miniapp context.
Findings
- None.
Decision
Approving because the change matches issue #768, the connector type remains compatible after the package upgrade, and I do not see a remaining correctness or design blocker in the updated miniapp connection flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
farcasterMiniApp()on line 50 ofwagmi.tsremoved; only the one insidewalletConnectorsviafarcasterWalletremainsconnect()directly when inside miniapp — Warpcast manages auth, so the gate was causing silent failures@farcaster/miniapp-wagmi-connector1.1.1 → 2.0.0,@farcaster/miniapp-sdk0.2.3 → 0.3.0 (no breaking API changes)Fixes #768
Test plan
npm run buildpasses🤖 Generated with Claude Code