Fix stale nonce in Zap two-step trade flows#790
Merged
realproject7 merged 2 commits intomainfrom Apr 3, 2026
Merged
Conversation
Add 500ms delay after approval waitForTransactionReceipt in all three approve→write paths (Zap ERC-20 buy, PLOT buy, sell). Gives the wallet provider time to update its internal nonce before the second writeContractAsync call, preventing "nonce too low" simulation failures. Fixes #788 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Instead of a hardcoded 500ms delay, wrap the post-approval writeContractAsync calls in retryOnNonceError(). On first attempt, if the wallet provider's nonce cache is stale, the nonce error is caught and retried once after 500ms. No delay on fast providers; reliable recovery on slow ones. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Apr 3, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The change is minimal, focused, and it covers the three two-step approval flows implicated by the bug report. I did not find a code-level regression or a missed path in TradingWidget.tsx.
Findings
- None.
Decision
Approved on code review. I did not wait for CI or runtime validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitForTransactionReceiptin all three approve→write paths inTradingWidget.tsxwriteContractAsyncuses a stale cached nonce after an approval tx confirmsAffected Flows
Test Plan
Fixes #788
🤖 Generated with Claude Code