Redesign storyline header with Moleskine cover + info panel#794
Redesign storyline header with Moleskine cover + info panel#794realproject7 merged 3 commits intomainfrom
Conversation
Replace plain text header with Moleskine book cover (left) + structured info panel (right) layout inspired by Korean web fiction stores. - Desktop: cover left, info right with label-value rows - Mobile: cover centered on top, info below - Reuses Moleskine notebook styling from Reader tab holdings cards - Info panel: title, rating+views, writer with PFP, plots, genre - Market stats grid preserved below Fixes #785 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The redesign direction is fine, but there is a real header regression in the rating/views row for stories with no ratings yet.
Findings
- [medium]
RatingSummaryreturnsnullwhen a storyline has zero ratings, but the separator dot is rendered unconditionally. That means unrated stories will show a leading·before the view count in the new header.- File:
src/app/story/[storylineId]/page.tsx:306 - Suggestion: render the separator only when
RatingSummaryis present, or have a small wrapper that conditionally includes both the rating block and the separator together.
- File:
Decision
Requesting changes because the redesign introduces a visible regression for unrated storylines.
Create RatingSummaryWithSeparator component that renders the rating plus trailing dot separator together. When no ratings exist, both the rating and separator are hidden — no orphaned dot before views. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The orphaned separator bug is fixed, but the follow-up patch leaves one remaining issue in the page module.
Findings
- [low]
RatingSummaryis still imported insrc/app/story/[storylineId]/page.tsxeven though the header now uses onlyRatingSummaryWithSeparator. That unused import is likely to fail lint and should be removed before merge.- File:
src/app/story/[storylineId]/page.tsx:10 - Suggestion: drop the unused
RatingSummaryimport.
- File:
Decision
Keeping this in request-changes until the page module is clean and merge-ready.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The orphaned separator issue is fixed and the remaining page-module cleanup is done. I do not have further review blockers on this redesign PR.
Findings
- None.
Decision
Approved on code review. CI was still pending when I reviewed.
Summary
profile/[address]/page.tsx:1500)Layout
Desktop (sm+): Moleskine cover (left, 160px) + info panel (right) with title, rating+views, labeled rows
Mobile: Cover centered on top (130px), info below centered
Wireframe Match
Test Plan
Fixes #785
🤖 Generated with Claude Code