Format DonateWidget balance, extract shared formatTokenAmount#799
Merged
realproject7 merged 1 commit intomainfrom Apr 3, 2026
Merged
Format DonateWidget balance, extract shared formatTokenAmount#799realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Extract formatTokenAmount from TradingWidget to shared lib/format.ts. Apply to DonateWidget balance and donation amount displays. Values now show 2dp with commas for >= 1, 4dp for small, scientific for tiny. Fixes #796 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Apr 3, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR fixes the raw 18-decimal display in DonateWidget and reuses the existing TradingWidget formatting logic by moving it into a shared helper. The change is focused and matches issue #796.
Findings
- No blocking findings.
Decision
Approving. The balance and donation summary now use shared token-amount formatting, which satisfies the issue's acceptance criteria.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatTokenAmountfromTradingWidget.tsxto sharedlib/format.tsDonateWidget.tsxbalance display and donation amountTradingWidget.tsxnow imports from shared location (no behavior change)Before/After
5034.425044895956140455 PLOT→5,034.43 PLOT68.623631443223832041 PLOT→68.62 PLOTTest Plan
Fixes #796
🤖 Generated with Claude Code