Deduplicate RatingSummary, add aria-hidden to separator#800
Merged
realproject7 merged 1 commit intomainfrom Apr 3, 2026
Merged
Deduplicate RatingSummary, add aria-hidden to separator#800realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Add optional `separator` prop to RatingSummary that renders a trailing dot when ratings exist. Delete RatingSummaryWithSeparator duplicate. Add aria-hidden="true" to the decorative separator dot. Fixes #797 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Apr 3, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR removes the duplicated rating query/render path by extending RatingSummary with an optional separator, and it adds aria-hidden="true" to the decorative dot. I did not find a code-level regression in the storyline header path.
Findings
- No blocking findings.
Decision
Approving. This satisfies issue #797's single-source-of-truth and accessibility requirements without changing the no-ratings behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
separatorprop toRatingSummarythat renders a trailing dot when ratings existRatingSummaryWithSeparatorcomponent (was copy-pasting query + render logic)aria-hidden="true"to the decorative separator dot<RatingSummary separator />instead of the duplicateChanges
src/components/RatingSummary.tsx— addedseparatorprop,aria-hiddenon dotsrc/components/RatingSummaryWithSeparator.tsx— deletedsrc/app/story/[storylineId]/page.tsx— updated import and usageTest Plan
Fixes #797
🤖 Generated with Claude Code