Skip to content

[#845] Manage tab: all agents with OWS/Direct badges#850

Merged
realproject7 merged 3 commits intomainfrom
task/845-manage-all-agents
Apr 5, 2026
Merged

[#845] Manage tab: all agents with OWS/Direct badges#850
realproject7 merged 3 commits intomainfrom
task/845-manage-all-agents

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Added AgentManageAll wrapper that enumerates all ERC-8004 agent NFTs owned by the connected wallet
  • Renders an AgentManage card per agent with OWS Writer / Direct badge
  • Existing per-agent management (edit URI, change wallet, unset wallet) preserved
  • Empty state for no owned agents
  • Version bumped to 0.1.17

Test plan

  • Manage tab shows all owned agents (not just one)
  • OWS Writer badge shown for OWS-bound agents
  • Direct badge shown for standard registered agents
  • Edit agent URI works per-agent
  • Change Agent Wallet flow works per-agent
  • Unset Wallet works per-agent
  • Empty state shown when no agents owned

Fixes #845

🤖 Generated with Claude Code

Add AgentManageAll wrapper that enumerates all ERC-8004 agent NFTs
owned by the connected wallet and renders an AgentManage card for
each. Add source badge (OWS Writer / Direct) to agent headers.
Existing change wallet, unset wallet, and edit URI flows preserved
per-agent. Bump to v0.1.17.

Fixes #845

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Apr 5, 2026 7:06am

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The wrapper for rendering multiple agent cards is a good start, but this revision does not satisfy issue #845 yet. The Manage tab still preserves the old wallet-change flow instead of the new OWS binding-proof flow, and the page still gates access to Manage using the old single-agent detection heuristic.

Findings

  • [high] The OWS wallet-change flow still requires the user to switch their browser wallet to the new agent wallet and sign EIP-712 locally in RainbowKit. That is the old direct-wallet flow, not the binding-proof round trip required for OWS writers in issue #845.
    • File: src/components/AgentManage.tsx:488
    • Suggestion: for OWS-bound agents, mirror the new issue #842 flow: collect the new OWS wallet + proof generated by the OWS app, then have the owner submit setAgentWallet on-chain.
  • [high] The page still decides whether to show Manage vs Register using the old dbDetected / needsRpcFallback heuristic before it ever renders AgentManageAll. If a wallet already has a user row but agent_id is null, the code explicitly skips balanceOf() and can still drop the user into Register even when they own agents, so the new multi-agent Manage view never appears.
    • File: src/app/agents/page.tsx:47
    • Suggestion: base the Register/Manage gate on actual owner/agent ownership checks compatible with the new multi-agent flow, rather than the old single-agent DB shortcut.

Decision

Requesting changes because the current head still misses the new OWS binding-proof requirement and can still hide the Manage tab from valid agent owners.

OWS agents can't sign EIP-712 via RainbowKit since their wallet is
on the user's local machine. Add a paste-based flow: user goes to
OWS app to generate wallet bind signature + deadline, pastes both
on PlotLink, then PlotLink calls setAgentWallet. Direct agents keep
the existing browser-based RainbowKit sign flow.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The new OWS paste-based wallet-change flow fixes my first blocker. But the Manage tab is still gated by the old single-agent detection path before AgentManageAll ever renders, so the multi-agent view can still be hidden from valid owners.

Findings

  • [high] The page still decides Manage vs Register using the old dbDetected / needsRpcFallback heuristic before it renders AgentManageAll. If a wallet already has a user row but agent_id is null, the code skips balanceOf() and can still land in Register even when that wallet owns agents, so the new multi-agent Manage view never appears.
    • File: src/app/agents/page.tsx:47
    • Suggestion: base the Register/Manage gate on owner/agent ownership checks that are compatible with the new multi-agent flow, or render AgentManageAll for connected wallets and let that component own the empty state.

Decision

Requesting changes because the current head still can hide the new Manage experience from wallets that actually own agents.

balanceOf was only checked for completely unknown wallets. Now checked
for any connected wallet without agent_id in DB, so wallets that own
agent NFTs but have no agent_id row still route to AgentManageAll.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The latest revision resolves the remaining Manage-tab blocker. Wallets without agent_id in the DB now still check balanceOf() and route into the multi-agent Manage view when they own agent NFTs, and OWS agents use the new paste-based wallet change flow.

Findings

  • None.

Decision

Approving. The Manage tab now shows owned agents, displays the OWS/Direct badges, preserves per-agent management actions, and supports the new OWS wallet-change path without the earlier page-gating bug.

@realproject7 realproject7 merged commit 6360229 into main Apr 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[#841] Manage tab: display all agents + change agent wallet for OWS writers

2 participants