[#846] Display "{human}'s AI Writer" via ERC-8004 owner + FID#851
[#846] Display "{human}'s AI Writer" via ERC-8004 owner + FID#851realproject7 merged 2 commits intomainfrom
Conversation
Add getAgentOwnerProfile server action that looks up an agent writer's
owner Farcaster profile. Update WriterIdentity (server) and
WriterIdentityClient to show "{owner}'s AI Writer" when the writer is
an ERC-8004 agent with an owner who has a Farcaster profile.
Update StoryCard, story detail, and plot detail pages to pass
writerType to identity components. Add "Operated by" section to
profile page showing owner's Farcaster avatar + name with
"ERC-8004 Verified" badge.
Falls back to regular Farcaster profile or truncated address when
owner has no FID. Bump to v0.1.18.
Fixes #846
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The owner-linked identity path is in place, but the fallback behavior still does not match issue #846. When an agent owner has no FID, the UI falls back to the writer wallet's own Farcaster/address display instead of a plain agent label, so agent-written stories can still render as a bare wallet or regular profile rather than an AI writer identity.
Findings
- [high] The new writer-identity components only render the human-linked label when
getAgentOwnerProfile()succeeds. If the writer is an agent but the owner has no FID, both components fall back to the writer wallet's own profile/address (@usernameor truncated wallet) instead of the required plain agent fallback such asAI Writer #<agentId>. That misses the explicit fallback behavior in issue #846 and leaves agent-written stories mislabeled on cards and detail pages.- File:
src/components/WriterIdentity.tsx:31 - Suggestion: keep an agent fallback path when
writerType === 1, using the agent row'sagent_id/agent_nameeven when the owner profile lookup returns null, rather than falling through to the writer wallet identity.
- File:
Decision
Requesting changes because the current head still does not satisfy the required agent fallback behavior when the owner lacks a Farcaster profile.
When a writer is an agent but the owner has no Farcaster profile,
show "AI Writer #{agentId}" instead of falling through to the
agent wallet's own Farcaster identity. getAgentOwnerProfile now
returns agent info even without owner FID (ownerProfile: null).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The latest revision resolves the remaining fallback issue in the writer identity flow. Agent writers now show the owner-linked label when an owner Farcaster profile exists, and they correctly fall back to a plain AI Writer #<id> label when the owner has no FID.
Findings
- None.
Decision
Approving. The owner-based identity display, profile-page owner section, and agent fallback behavior now align with issue #846.
Summary
getAgentOwnerProfileserver action: looks up agent's owner Farcaster profile via DBWriterIdentity(server) andWriterIdentityClientto show "{owner}'s AI Writer" for ERC-8004 agentswriterTypeto identity componentsTest plan
Fixes #846
🤖 Generated with Claude Code