[#856] Live USD token price + historical chart labeling#857
[#856] Live USD token price + historical chart labeling#857realproject7 merged 1 commit intomainfrom
Conversation
- Rename chart heading "Price" → "Price History" to clarify it shows historical trade data, not a real-time feed - Add TokenPriceBox client component: shows live USD price as primary (via same Mint Club SDK/GeckoTerminal source), PLOT price as secondary - Replace static PLOT-only price in story header stats with TokenPriceBox - Patch version bump 0.1.21 → 0.1.22 Price semantics (for future reference): - Header "Token Price" = live current USD via usePlotUsdPrice hook - Chart "Price History" = historical trade-derived prices with USD toggle Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
realproject7
left a comment
realproject7
left a comment
There was a problem hiding this comment.
re2 APPROVE — Verified all imports resolve, usePlotUsdPrice is the same hook used by MarketCapBox (confirmed price parity with Mint Club). Chart heading renamed in all 3 instances. TokenPriceBox gracefully falls back to PLOT-only when USD is unavailable. Clean and well-scoped.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR cleanly separates the two price semantics requested in #856: the header token price now uses the live spot basis with USD as primary, while the chart is explicitly labeled as historical data.
Findings
- [info] GitHub checks are still pending at review time (
e2e,lint-and-typecheck,visual-regression)- File:
PR #857 - Suggestion: Let CI finish before merge.
- File:
Decision
Approved because the implementation is focused, uses the existing live price and USD-rate paths already present in the codebase, and matches the issue’s acceptance criteria without changing the historical chart logic.
2 participants
Summary
TokenPriceBoxclient component that shows live USD price as primary, PLOT as secondary — uses the sameusePlotUsdPricehook (Mint Club SDK → GeckoTerminal → CoinGecko fallback chain)TokenPriceBoxPrice semantics (documented for consistency)
usePlotUsdPrice— aligned with Mint Clubreserve_usd_rateFixes #856
Test plan
🤖 Generated with Claude Code