[#864] Reduce PR CI cost by removing visual regression job#869
Merged
realproject7 merged 2 commits intomainfrom Apr 12, 2026
Merged
[#864] Reduce PR CI cost by removing visual regression job#869realproject7 merged 2 commits intomainfrom
realproject7 merged 2 commits intomainfrom
Conversation
- Drop the visual-regression job from ci.yml (remains manual-only in update-snapshots.yml) - Add concurrency group so superseded PR runs are auto-canceled - PR CI now runs only lint-and-typecheck + e2e Fixes #864 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
requested changes
Apr 12, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The ci.yml change is aligned with part of the ticket, but the PR does not include the other workflow/doc updates explicitly required by issue #864.
Findings
- [high] The issue scope calls for updating
.github/workflows/update-snapshots.ymlandCLAUDE.mdin addition toci.yml, but this PR changes only.github/workflows/ci.yml.- File:
.github/workflows/ci.yml:1 - Suggestion: Include the prepared
update-snapshots.ymlconcurrency/timeout changes and theCLAUDE.mdguidance update, or narrow the issue/acceptance criteria before merging.
- File:
Decision
Requesting changes because the PR does not satisfy the full accepted scope for #864 as written.
- Add concurrency group and 15-min timeout to update-snapshots.yml - Update CLAUDE.md with visual regression manual-only guidance and updated repo structure listing both workflow files Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Apr 12, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR now includes the full accepted scope for #864 and keeps the change set limited to workflow/doc updates only.
Findings
- No further findings.
Decision
Approving. PR CI is reduced to lint-and-typecheck plus e2e, visual regression remains manual-only with concurrency/timeout in the dedicated workflow, and no runtime app files are changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visual-regressionjob from PR CI — it remains available as manual-only viaUpdate Visual Snapshotsworkflow (update-snapshots.yml)concurrencygroup withcancel-in-progress: trueso superseded PR CI runs are auto-canceledlint-and-typecheckande2e(no app runtime changes)Changes
.github/workflows/ci.yml: removed visual-regression job (25 lines), added concurrency block (4 lines)Test plan
lint-and-typecheckande2ejobsUpdate Visual Snapshotsworkflow remains available for manual dispatchFixes #864
🤖 Generated with Claude Code