[#29] Dashboard trading stats

[realproject7]

Summary

• Writer dashboard: Added per-story token price (priceForNextMint), TVL (tokenBond), and donations total — displayed in stats grid via new WriterTradingStats component
• Reader dashboard: Replaced Phase 5 placeholder with real ReaderPortfolio component — shows token holdings (balanceOf), portfolio value (holdings * priceForNextMint), 24h price change per holding, and best-performing pick highlight

Test plan

• npm run lint passes
• npm run typecheck passes
• Writer dashboard shows token price, TVL, and donations per storyline
• Reader dashboard shows portfolio with holdings, values, and 24h changes
• Portfolio handles zero holdings gracefully
• Best pick shows highest 24h gainer

Fixes #29

🤖 Generated with Claude Code

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The dashboards are close, but the writer side still misses the key earnings stat from the revised issue comment, and the new TVL display reintroduces the reserve-decimal bug we already fixed in the shared price utilities.

Findings

• [high] The revised issue comment and overnight queue require writer dashboard earnings to include donations plus royalties from MCV2_Bond.getRoyaltyInfo(). WriterTradingStats only shows Donations, while royalties remain in the separate ClaimRoyalties control and are not incorporated into an earnings total. That means the primary writer stat required by #29 is still missing.
  • File: src/components/WriterTradingStats.tsx:50
  • Suggestion: read getRoyaltyInfo() for the storyline token and expose an Earnings stat that combines donations + current royalty amount, or otherwise present royalties as part of the required writer earnings summary.
• [medium] WriterTradingStats formats tokenBond().reserveBalance with formatUnits(..., 18), hardcoding 18 decimals instead of using the reserve token's actual decimals or the shared getTokenTVL() utility. This recreates the same unit bug we already flagged in PR #82 for non-18-decimal reserves.
  • File: src/components/WriterTradingStats.tsx:79
  • Suggestion: use getTokenTVL() or fetch the reserve token decimals before formatting TVL.

Decision

Requesting changes because the writer dashboard still does not meet the required earnings behavior, and the TVL formatting is unsafe.

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The TVL formatting issue is fixed, but the writer dashboard still misses the primary earnings stat required by the revised issue comment and overnight queue.

Findings

• [high] The revised issue comment for #29 says writer stats should show total earnings as donations from Supabase plus royalties from getRoyaltyInfo(), and the overnight queue merge checklist likewise calls for earnings, TVL, token price per storyline. WriterTradingStats now shows Donations and Royalties as separate fields, but it still does not expose a combined Earnings total anywhere. That means the required headline writer metric is still absent.
  • File: src/components/WriterTradingStats.tsx:70
  • Suggestion: add an Earnings stat that sums donations + current royalty amount, or otherwise rename/restructure the writer stats so the combined earnings figure is explicitly presented.

Decision

Requesting one final change because the writer dashboard still does not present the required combined earnings metric.

[project7-interns]

Verdict: APPROVE

Summary

The final update adds the required combined writer earnings metric while keeping the earlier TVL-decimal and reader-portfolio fixes intact. The dashboards now match the revised March 15 issue comment and overnight queue for #29.

Findings

• No blocking findings.

Decision

Approving because the writer dashboard now shows earnings, token price, and TVL per storyline, and the reader dashboard exposes holdings, portfolio value, and 24h change using the shared on-chain utilities.