[#886] Add campaign hero + milestone progress track#905
Conversation
- CampaignHero: time progress bar, mcap display + progress toward next milestone, stats row (participants, PL earned, PLOT price), lockup proof link - MilestoneTrack: visual track Bronze→Silver→Gold with mcap markers, tier details (target, pool %, PLOT amount), current position - Updated /airdrop page to compose hero + milestone + referral sections Fixes #886 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The components render and use the status endpoint, but the implementation still misses a core piece of the requested milestone/economics display.
Findings
- [medium] The milestone cards show unlocked PLOT amounts (
5,000 PLOT,15,000 PLOT, etc.) instead of the requested pool value at each milestone level. The issue explicitly asks for pool value display in the hero and for each milestone tier, with the examplePool value if Gold: $3,500,000.- File:
src/components/airdrop/MilestoneTrack.tsx:84 - Suggestion: compute and render the milestone pool value in USD (or otherwise in the same economic-value terms the ticket specifies), rather than only the unlocked token amount.
- File:
- [medium] The hero section also omits the requested pool-value display entirely. It shows participants / PL earned / price, but not the milestone-level pool value callout described in the ticket.
- File:
src/components/airdrop/CampaignHero.tsx:102 - Suggestion: add the pool-value summary for the current/next milestone state in the hero so the page satisfies the issue scope end-to-end.
- File:
Decision
Requesting changes because the PR still does not implement the milestone pool-value presentation required by the ticket.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The new hero and milestone components are close, but PR #905 still misses two acceptance-criteria items from issue #886.
Findings
- [medium] The hero component does not render any pool-value summary, even though the issue explicitly requires a pool value display in the hero section.
- File:
src/components/airdrop/CampaignHero.tsx:55 - Suggestion: Add a hero row that shows the pool value at the relevant milestone level, matching the issue spec (for example the Gold pool value shown in the mockup).
- File:
- [medium] The milestone track renders milestone markers only; it never renders a separate current-market-cap marker on the track, which is explicitly called out in the issue scope.
- File:
src/components/airdrop/MilestoneTrack.tsx:46 - Suggestion: Add a distinct current-position marker anchored to
overallProgressso users can see the live mcap position independently from the filled bar.
- File:
Decision
Requesting changes because issue #886's required hero pool-value display and explicit current-position marker on the milestone track are not implemented yet.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up update resolves the two missing requirements from issue #886. The hero now includes a pool-value summary, and the milestone track now renders a distinct current-market-cap marker.
Findings
- No remaining code-level blockers in the changed files.
Decision
Approving because the requested UI requirements are now implemented and the PR remains focused on issue #886.
Summary
/airdroppage to compose hero + milestone + referral sections/api/airdrop/statuswith 60s auto-refreshFiles Changed
src/components/airdrop/CampaignHero.tsx— newsrc/components/airdrop/MilestoneTrack.tsx— newsrc/app/airdrop/page.tsx— updated to use new componentsTest plan
/airdroppage renders hero with time progress barFixes #886
🤖 Generated with Claude Code