[#889] Add weekly snapshots component#908
Merged
realproject7 merged 2 commits intomainfrom Apr 21, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
requested changes
Apr 21, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The recap UI is close, but it does not enforce the reverse-chronological ordering required by issue #889.
Findings
- [medium] The component renders
data.snapshotsin API order without sorting. Issue #889 explicitly requires latest week first, so this UI will be wrong whenever the endpoint returns snapshots oldest-first or unsorted.- File:
src/components/airdrop/WeeklySnapshots.tsx:58 - Suggestion: Sort snapshots descending by
weekStartorweekNumberbefore rendering so the latest recap is always at the top.
- File:
Decision
Requesting changes because the component currently relies on implicit backend ordering for a user-visible requirement.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Apr 21, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up update resolves the ordering issue from my prior review. Weekly recap cards are now explicitly sorted descending by weekNumber, so the latest week renders first regardless of API order.
Findings
- No remaining code-level blockers in the changed files.
Decision
Approving because the weekly snapshots behavior I reviewed now matches issue #889.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #889
Summary
/airdroppage between Leaderboard and MilestoneTrackTest plan
🤖 Generated with Claude Code